| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
This was inherited from some other code; perhaps the idea
was to ensure the console is in a consistent state before starting
a progress bar, but it causes extra newlines which is distracting.
|
|
|
|
|
|
|
| |
Share its static var goodness with clients. This will be used in
rpm-ostree from various places which sometimes do use a `GLnxConsole`
and sometimes don't, so it's more convenient to make it its own
function.
|
|
|
|
|
| |
For TTYs, it slows things down pointlessly. For non-TTYs like Jenkins jobs, it
creates a ton of output that obscures useful information.
|
|
|
|
|
|
| |
The idea was clearly to avoid useless updates, but we never actually *set* these
values. Drop the code for now to avoid confusion, I'll reimplement this in a
better way.
|
|
|
|
|
| |
IMO, it looks bad to have a really big progress bar. I personally usually work
on a 27" monitor with maximized terminals.
|
|
|
|
| |
It's often really useful to see the counts, not just the percentage.
|
|
|
|
|
|
| |
The `percentage` var is a guint and so is always >= 0.
Coverity CID: 163703
|
|
|
|
|
|
|
|
| |
It’s possible that text is NULL on this path.
Coverity CID: 1376570
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
| |
We need to handle our "empty to NULL canonicalization" before
doing the length.
Coverity CID: 1376570
|
|
|
|
|
|
|
| |
A wild sordid tale of substractions and unsigned integers leads this
team of variables down a loonng path...
Reported-by: Gatis Paeglis <gatis.paeglis@qt.io>
|
|
|
|
|
|
|
| |
Padding in the percentage case was useless (and actually didn't work
properly) since all the real estate is taken up by the text and the bar.
We only need padding in the text case, in case the new string is
shorter.
|
|
|
|
| |
Not sure if it ever worked. We need to not print the bars, etc.
|
|
|
|
| |
We had this internally, just need to expose it.
|
|
|
|
|
| |
The previous fix added the last character of text, but failed to
account for the space we're adding.
|
|
|
|
|
| |
Not sure why we were doing this...I guess people were working around
it by adding their own spaces?
|
|
|
|
|
| |
This way, one can unlock the console while still using the cleanup
macro. Otherwise we miss a lot of the ergonomics of cleanup macros.
|
|
|
|
|
|
|
|
|
| |
Doing nothing isn't super useful; if you're using e.g. rpm-ostree in
Jenkins you want to see *something* from the "live tail".
This is a basic line-per-change implementation.
Closes: https://github.com/GNOME/libglnx/pull/6
|
|
|
|
| |
They'll be used by rpm-ostree at least.
|
|
This contains some basic progress bar drawing code for now.
|