From 4040f55ac516ef2473884928a2b9d22efa96cca3 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Fri, 24 Mar 2017 10:21:22 -0400 Subject: errors: Fix legacy set_prefix_error_from_errno() We were missing the previous automatic `: ` addition; noticed in a failing ostree test. Fix this by just calling the new API as the non-prefix case does too. --- glnx-errors.h | 4 +--- tests/test-libglnx-errors.c | 8 +++++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/glnx-errors.h b/glnx-errors.h index b891f96..2f6b962 100644 --- a/glnx-errors.h +++ b/glnx-errors.h @@ -128,9 +128,7 @@ glnx_throw_errno_prefix (GError **error, const char *fmt, ...) #define glnx_set_prefix_error_from_errno(error, format, args...) \ do { \ - glnx_set_error_from_errno (error); \ - g_prefix_error (error, format, args); \ + glnx_throw_errno_prefix (error, format, args); \ } while (0); - G_END_DECLS diff --git a/tests/test-libglnx-errors.c b/tests/test-libglnx-errors.c index 7c7459c..7950244 100644 --- a/tests/test-libglnx-errors.c +++ b/tests/test-libglnx-errors.c @@ -79,9 +79,15 @@ test_error_errno (void) fd = open (noent_path, O_RDONLY); if (fd < 0) { + g_autofree char *expected_prefix = g_strdup_printf ("Failed to open %s", noent_path); g_assert (!glnx_throw_errno_prefix (&error, "Failed to open %s", noent_path)); g_assert_error (error, G_IO_ERROR, G_IO_ERROR_NOT_FOUND); - g_assert (g_str_has_prefix (error->message, glnx_strjoina ("Failed to open ", noent_path))); + g_assert (g_str_has_prefix (error->message, expected_prefix)); + g_clear_error (&error); + /* And test the legacy wrapper */ + glnx_set_prefix_error_from_errno (&error, "Failed to open %s", noent_path); + g_assert_error (error, G_IO_ERROR, G_IO_ERROR_NOT_FOUND); + g_assert (g_str_has_prefix (error->message, expected_prefix)); g_clear_error (&error); } else -- cgit v1.2.1