From fa597642871e284bb1b7c86996bb58c79c9c799c Mon Sep 17 00:00:00 2001 From: Marcus Meissner Date: Sun, 12 Jan 2020 14:52:17 +0100 Subject: fixed conditional building of lumix driver. automake method did not work, so just build an empty driver if we do not have libxml2 or libcurl fixes https://github.com/gphoto/gphoto2/issues/281 fixes https://github.com/gphoto/libgphoto2/issues/466 --- camlibs/lumix/Makefile-files | 6 +----- camlibs/lumix/lumix.c | 47 ++++++++++++++++++++++++++++++++------------ 2 files changed, 35 insertions(+), 18 deletions(-) diff --git a/camlibs/lumix/Makefile-files b/camlibs/lumix/Makefile-files index d8d151ff8..1670b332b 100644 --- a/camlibs/lumix/Makefile-files +++ b/camlibs/lumix/Makefile-files @@ -1,13 +1,9 @@ # -*- Makefile -*- EXTRA_DIST += lumix/README.lumix - noinst_DATA += lumix/README.lumix -if BUILD_LUMIX + EXTRA_LTLIBRARIES += lumix.la -else -EXTRA_DIST += lumix/lumix.c -endif lumix_la_SOURCES = lumix/lumix.c lumix_la_CFLAGS = $(AM_CFLAGS) $(NO_UNUSED_CFLAGS) $(CFLAGS) $(LIBXML2_CFLAGS) $(LIBCURL_CFLAGS) diff --git a/camlibs/lumix/lumix.c b/camlibs/lumix/lumix.c index eeb0a0b54..3115b0648 100644 --- a/camlibs/lumix/lumix.c +++ b/camlibs/lumix/lumix.c @@ -24,15 +24,20 @@ */ #include "config.h" + #include #include -#include +#ifdef HAVE_LIBCURL +# include +#endif #include -#include -#include #include -#include -#include +#ifdef HAVE_LIBXML2 +# include +# include +# include +# include +#endif #include @@ -82,6 +87,8 @@ # define N_(String) (String) #endif +#if defined(HAVE_LIBCURL) && defined(HAVE_LIBXML2) + char* CDS_Control = ":60606/Server0/CDS_control"; int ReadoutMode = 2; // this should be picked up from the settings.... 0-> JPG; 1->RAW; 2 -> Thumbnails char* cameraShutterSpeed = "B"; // //placeholder to store the value of the shutterspeed set in camera; "B" is for bulb. @@ -370,14 +377,6 @@ storage_info_func (CameraFilesystem *fs, /**********************************************************************/ -int -camera_id (CameraText *id) -{ - strcpy(id->text, "Lumix Wifi"); - - return GP_OK; -} - static size_t write_callback(char *contents, size_t size, size_t nmemb, void *userp) { @@ -1919,3 +1918,25 @@ camera_init (Camera *camera, GPContext *context) } else return GP_ERROR_IO; } + +#else +/* no XML2 or no CURL -> no camera here */ +int +camera_init (Camera *camera, GPContext *context) +{ + return GP_OK; +} + +int camera_abilities (CameraAbilitiesList *list) +{ + return GP_OK; +} +#endif + +int +camera_id (CameraText *id) +{ + strcpy(id->text, "Lumix Wifi"); + + return GP_OK; +} -- cgit v1.2.1