From 0dbeaf7cbf30ab88ac7aea3e7d3f24df8dc0309f Mon Sep 17 00:00:00 2001 From: Hans Ulrich Niedermann Date: Tue, 5 Oct 2021 15:50:32 +0200 Subject: Use consistently named non-reserved CPP macros for header files C preprocessor macros beginning/ending with underscores are reserved for system use as well as macros containing a double underscore anywhere, so application software macros are supposed to be named differently. For a header file gphoto2-abilities-list.h, this consistently uses a macro name LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H for the usual #ifndef LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H #define LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H ... content of the header file ... #endif /* !defined(LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H) */ Found using "clang -Weverything". This should work, unless when run with an ancient C preprocessor which might only the first 8 or 10 characters to distinguish macro names and ignores the remainder of the name. --- camlibs/sq905/sq905.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'camlibs/sq905') diff --git a/camlibs/sq905/sq905.h b/camlibs/sq905/sq905.h index 1ba9ddb30..5475ecfa9 100644 --- a/camlibs/sq905/sq905.h +++ b/camlibs/sq905/sq905.h @@ -1,5 +1,5 @@ -#ifndef __SQ905_H__ -#define __SQ905_H__ +#ifndef CAMLIBS_SQ905_SQ905_H +#define CAMLIBS_SQ905_SQ905_H #include @@ -58,5 +58,6 @@ sq_preprocess (SQModel model, int comp_ratio, int sq_decompress (SQModel model, unsigned char *output, unsigned char *data, int w, int h); -#endif + +#endif /* !defined(CAMLIBS_SQ905_SQ905_H) */ -- cgit v1.2.1