| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's this Huawei E820W which replies several OPEN DONE messages, even using a
transaction ID which doesn't belong to the original OPEN message.
E.g.
Send OPEN message (transaction 1)
<<<<<< RAW:
<<<<<< length = 16
<<<<<< data = 01:00:00:00:10:00:00:00:01:00:00:00:00:06:00:00
Get OPEN DONE message (transaction 1)
>>>>>> RAW:
>>>>>> length = 16
>>>>>> data = 01:00:00:80:10:00:00:00:01:00:00:00:00:00:00:00
Send COMMAND message (transaction 2)
<<<<<< RAW:
<<<<<< length = 48
<<<<<< data = 03:00:00:00:30:00:00:00:02:00:00:00:01:00:...
Receive OPEN DONE message (transaction 2) <---------- ERROR
>>>>>> RAW:
>>>>>> length = 16
>>>>>> data = 01:00:00:80:10:00:00:00:02:00:00:00:00:00:00:00
Then, get the COMMAND DONE message (transaction 2) as we expected
>>>>>> RAW:
>>>>>> length = 208
>>>>>> data = 03:00:00:80:D0:00:00:00:02:00:00:00:01:00:00:00:...
So, in order to handle this, match responses not only by transaction ID, but
also by expected message type.
|
| |
|
| |
|
|
|
|
|
| |
* use mbim_register_custom_service API to register a new service.
* use mbim_unregister_custom_service API to unregister it.
|
|
|
|
|
| |
This patch adds additional GMM cause codes defined in the 3GPP TS 24.008
specification to MbimNwError.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
This patch renames 'MBIM_CID_DEVICE_SERVICE_SUBSCRIBER_LIST' to
'MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST' to be consistent with the MBIM
specification. This CID is for subscribing notifications for CIDs that
the host is interested in, and is not related to mobile 'subscriber'.
|
| |
|
|
|
|
|
|
|
|
| |
This is not a license change; the library is still LGPLv2+, and the command line
tool GPLv2+.
For reference, see libqmi bug:
https://bugs.freedesktop.org/show_bug.cgi?id=74220
|
| |
|
| |
|
| |
|
|
|
|
|
| |
And avoid sscanf(). A single loop to validate contents and build the result is
enough.
|
| |
|
| |
|
| |
|
|
|
|
| |
The sscanf() parser seems not good enough to catch mismatched dashes.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
A MBIM device typically delays its response to an 'Open' command when it
has not completed the initialization process. This patch increases the
timeout of the MBIM device open operation from 15s to 30s to handle
situations where the device takes much longer to initialize.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This patch adds missing mbim_message_command_done_get_result() checks in
mbimcli to ensure that the status code in a command-done message reports
no error before parsing further parsing the response. It also adds
missing mbim_message_unref() calls to ensure that the response is freed
in case of an error.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
This patch modifies set_pin_input_parse and set_connect_activate_parse
in mbimcli-basic-connect.c to duplicate the strings in a string array,
before returning them to the caller, so that the string array can be
properly freed with g_strfreev.
|
|
|
|
| |
Also fixes a few indentation issues.
|
|
|
|
|
|
| |
This patch renames 'MBIM_REGISTRATION_FLAG_MANUAL_PACKET_SERVICE_AUTOMATIC_ATTACH' in
MbimRegistrationFlag to 'MBIM_REGISTRATION_FLAG_PACKET_SERVICE_AUTOMATIC_ATTACH' to be
consistent with the MBIM specification.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes the following incorrect enumeration type conversions:
mbimcli-basic-connect.c:298:52: error: implicit conversion from enumeration type 'MbimVoiceClass' to different enumeration type 'MbimDeviceType'
[-Werror,-Wenum-conversion]
voice_class_str = mbim_device_type_get_string (voice_class);
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~
mbimcli-basic-connect.c:1595:51: error: implicit conversion from enumeration type 'MbimActivationCommand' to different enumeration type 'MbimActivationState'
[-Werror,-Wenum-conversion]
MBIM_ACTIVATION_COMMAND_ACTIVATE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
|
|
|
|
|
|
| |
This patch removes the following invalid conversion from UUID_DSS to a
MBIM Context Type enumeration type:
mbim-uuid.c:343:16: error: implicit conversion from enumeration type 'MbimService' to
different enumeration type 'MbimContextType' [-Werror,-Wenum-conversion]
return MBIM_SERVICE_DSS;
~~~~~~ ^~~~~~~~~~~~~~~~
|
|
|
|
|
|
|
|
|
| |
storing transaction
Decouple the logic for connecting a cancellable from adding a timeout.
Also check if the cancellable has been connected already.
Signed-off-by: Greg Suarez <gpsuarez2512@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When receiving multiple fragments device_store_transaction() is called
for each fragment received thus adding a timeout callback for each
fragment. A timeout callback is only removed when all fragments are
received thus leaving dangling timeout callbacks. This leads to a crash
when the MbimDevice is finalized.
This patch checks if the transaction has already registered a timeout
callback before adding a new one.
Signed-off-by: Greg Suarez <gpsuarez2512@gmail.com>
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Just let '--phonebook-write' have an additional optional argument indicating
the entry index to update. If no index given, a new entry will be created.
|