diff options
| author | Fabrice Bellet <fabrice@bellet.info> | 2016-04-01 17:31:44 +0200 |
|---|---|---|
| committer | Olivier Crête <olivier.crete@collabora.com> | 2017-06-21 16:05:57 -0400 |
| commit | 11d4e37a030eb144a355dc26c705ef5aa5a975a7 (patch) | |
| tree | 9b92ef9258c750fa79691d193a0c0437ad3dc31b | |
| parent | 25b3eeec70b4e8e3b2154a18cdc8c5604f572012 (diff) | |
| download | libnice-11d4e37a030eb144a355dc26c705ef5aa5a975a7.tar.gz | |
conncheck: remove a useless pair recheck
This exception to the ICE spec is no longer needed: when a pair is in
the succeeded state, there is no needed to recheck it again upon
reception of an incoming stun request on it.
Differential Revision: https://phabricator.freedesktop.org/D884
| -rw-r--r-- | agent/conncheck.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/agent/conncheck.c b/agent/conncheck.c index 9950970..95e2556 100644 --- a/agent/conncheck.c +++ b/agent/conncheck.c @@ -2820,23 +2820,6 @@ static gboolean priv_schedule_triggered_check (NiceAgent *agent, NiceStream *str * that causes the ready -> connected transition. */ priv_update_check_list_state_for_ready (agent, stream, component); - - /* note: this new check is required by the new-dribble test, - * when early icheck on the peer controlled agent causes an - * incoming stun request to an already succeeded (and - * nominated) pair on the controlling agent. If the - * controlling agent doesn't retrigger a check with - * USE-CANDIDATE=1, the peer agent has no way to nominate it. - * - * This behavior differs from ICE spec 7.2.1.4 - */ - if ((agent->compatibility == NICE_COMPATIBILITY_RFC5245 || - agent->compatibility == NICE_COMPATIBILITY_WLM2009 || - agent->compatibility == NICE_COMPATIBILITY_OC2007R2) && - agent->controlling_mode) { - priv_add_pair_to_triggered_check_queue (agent, p); - conn_check_schedule_next(agent); - } } else if (p->state == NICE_CHECK_FAILED) { /* 7.2.1.4 Triggered Checks * If the state of the pair is Failed, it is changed to Waiting |