diff options
| author | Olivier Crête <olivier.crete@collabora.com> | 2014-01-24 03:02:38 -0500 |
|---|---|---|
| committer | Olivier Crête <olivier.crete@collabora.com> | 2014-01-31 01:49:07 -0500 |
| commit | ce90943f9538fa037f56d40972593c5911b7a1dc (patch) | |
| tree | c9a97c4c945268151b3a39526fddf7ae6ca91a14 /socket/tcp-bsd.c | |
| parent | f08083c8b5c65be0950990e488de4fb16714af44 (diff) | |
| download | libnice-ce90943f9538fa037f56d40972593c5911b7a1dc.tar.gz | |
socket: Add note that the packet dropping in tcp-bsd is broken behavior
Diffstat (limited to 'socket/tcp-bsd.c')
| -rw-r--r-- | socket/tcp-bsd.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/socket/tcp-bsd.c b/socket/tcp-bsd.c index 6e54b22..5792129 100644 --- a/socket/tcp-bsd.c +++ b/socket/tcp-bsd.c @@ -285,6 +285,9 @@ socket_send_message (NiceSocket *sock, const NiceOutputMessage *message) ret = message->length; } } else { + /* FIXME: This dropping will break http/socks5/etc + * We probably need a way to the upper layer to control reliability + */ /* If the queue is too long, drop whatever packets we can. */ if (g_queue_get_length (&priv->send_queue) >= MAX_QUEUE_LENGTH) { guint peek_idx = 0; |