diff options
author | Olivier CrĂȘte <olivier.crete@collabora.com> | 2016-06-02 19:22:50 -0400 |
---|---|---|
committer | Olivier CrĂȘte <olivier.crete@collabora.com> | 2016-06-02 19:23:49 -0400 |
commit | b58e852de6183f2bda4e7d322a35d18edf5cbbed (patch) | |
tree | 41f50888d1213ee389f8d30d874c36889e60b9a7 /socket/tcp-bsd.c | |
parent | baab2c3c7049f984cdca6ed622059c62ce8cebf7 (diff) | |
download | libnice-b58e852de6183f2bda4e7d322a35d18edf5cbbed.tar.gz |
socket: Assert trying to use free'd socket
Cleanly returnign makes no sense and may hide
worse problems.
Diffstat (limited to 'socket/tcp-bsd.c')
-rw-r--r-- | socket/tcp-bsd.c | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/socket/tcp-bsd.c b/socket/tcp-bsd.c index c02d6e2..3e5f5a8 100644 --- a/socket/tcp-bsd.c +++ b/socket/tcp-bsd.c @@ -237,9 +237,8 @@ socket_recv_messages (NiceSocket *sock, TcpPriv *priv = sock->priv; guint i; - /* Socket has been closed: */ - if (sock->priv == NULL) - return 0; + /* Make sure socket has not been freed: */ + g_assert (sock->priv != NULL); /* Don't try to access the socket if it had an error */ if (priv->error) @@ -291,9 +290,8 @@ socket_send_message (NiceSocket *sock, GError *gerr = NULL; gsize message_len; - /* Socket has been closed: */ - if (sock->priv == NULL) - return -1; + /* Make sure socket has not been freed: */ + g_assert (sock->priv != NULL); /* Don't try to access the socket if it had an error, otherwise we risk a * crash with SIGPIPE (Broken pipe) */ @@ -352,9 +350,8 @@ socket_send_messages (NiceSocket *sock, const NiceAddress *to, { guint i; - /* Socket has been closed: */ - if (sock->priv == NULL) - return -1; + /* Make sure socket has not been freed: */ + g_assert (sock->priv != NULL); for (i = 0; i < n_messages; i++) { const NiceOutputMessage *message = &messages[i]; |