socket: Assert trying to use free'd socket

Cleanly returnign makes no sense and may hide
worse problems.

1 files changed, 6 insertions, 9 deletions

diff --git a/socket/udp-bsd.c b/socket/udp-bsd.c
index d7346ff..3fac544 100644
--- a/socket/udp-bsd.c
+++ b/socket/udp-bsd.c
@@ -183,9 +183,8 @@ socket_recv_messages (NiceSocket *sock,
   guint i;
   gboolean error = FALSE;
 
-  /* Socket has been closed: */
-  if (sock->priv == NULL)
-    return 0;
+  /* Make sure socket has not been freed: */
+  g_assert (sock->priv != NULL);
 
   /* Read messages into recv_messages until one fails or would block, or we
    * reach the end. */
@@ -248,9 +247,8 @@ socket_send_message (NiceSocket *sock, const NiceAddress *to,
   GError *child_error = NULL;
   gssize len;
 
-  /* Socket has been closed: */
-  if (priv == NULL)
-    return -1;
+  /* Make sure socket has not been freed: */
+  g_assert (sock->priv != NULL);
 
   if (!nice_address_is_valid (&priv->niceaddr) ||
       !nice_address_equal (&priv->niceaddr, to)) {
@@ -292,9 +290,8 @@ socket_send_messages (NiceSocket *sock, const NiceAddress *to,
 {
   guint i;
 
-  /* Socket has been closed: */
-  if (sock->priv == NULL)
-    return -1;
+  /* Make sure socket has not been freed: */
+  g_assert (sock->priv != NULL);
 
   for (i = 0; i < n_messages; i++) {
     const NiceOutputMessage *message = &messages[i];