From 2493022a2486c93cf2573a5cd100839ea3a42ae3 Mon Sep 17 00:00:00 2001 From: Victor Toso Date: Tue, 15 Feb 2022 13:36:34 +0100 Subject: os: Fix leak of a GList * Just the cointainer is leaking. ==416264== 48 (24 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 1,444 of 2,345 ==416264== at 0x484486F: malloc (vg_replace_malloc.c:381) ==416264== by 0x496E3D8: g_malloc (in /usr/lib64/libglib-2.0.so.0.7000.3) ==416264== by 0x4987024: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7000.3) ==416264== by 0x495DDA9: g_list_prepend (in /usr/lib64/libglib-2.0.so.0.7000.3) ==416264== by 0x4958418: g_hash_table_get_values (in /usr/lib64/libglib-2.0.so.0.7000.3) ==416264== by 0x487A10F: osinfo_os_get_device_drivers_prioritized (osinfo_os.c:1248) ==416264== by 0x405835: test_device_driver_priority_helper (test-os.c:236) ==416264== by 0x4059E2: test_device_driver_prioritized_priority (test-os.c:267) ==416264== by 0x4992BD5: ??? (in /usr/lib64/libglib-2.0.so.0.7000.3) ==416264== by 0x49928FA: ??? (in /usr/lib64/libglib-2.0.so.0.7000.3) ==416264== by 0x49928FA: ??? (in /usr/lib64/libglib-2.0.so.0.7000.3) ==416264== by 0x49930A9: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7000.3) Signed-off-by: Victor Toso --- osinfo/osinfo_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/osinfo/osinfo_os.c b/osinfo/osinfo_os.c index 022bfe4..b81d16b 100644 --- a/osinfo/osinfo_os.c +++ b/osinfo/osinfo_os.c @@ -1258,6 +1258,7 @@ OsinfoDeviceDriverList *osinfo_os_get_device_drivers_prioritized(OsinfoOs *os) osinfo_list_add(OSINFO_LIST(device_drivers), OSINFO_ENTITY(l->data)); } + g_list_free(sorted); return device_drivers; } -- cgit v1.2.1