From be4481a5cc05091ca77e9a8daab9ab02f28a8813 Mon Sep 17 00:00:00 2001 From: Victor Toso Date: Tue, 15 Feb 2022 10:41:09 +0100 Subject: image: Fix leaks in osinfo_image_get_os_variants() ==382381== 48 bytes in 2 blocks are definitely lost in loss record 1,441 of 2,342 ==382381== at 0x484486F: malloc (vg_replace_malloc.c:381) ==382381== by 0x496E3D8: g_malloc (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x4987024: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x4963A2A: g_list_copy_deep (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x4883EE5: osinfo_image_get_os_variants (osinfo_image.c:353) ==382381== by 0x402C6A: test_loaded (test-image.c:74) ==382381== by 0x4992BD5: ??? (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x49928FA: ??? (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x49930A9: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x49930D0: g_test_run (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x402386: main (test-image.c:114) ==382381== ==382381== 686 (80 direct, 606 indirect) bytes in 2 blocks are definitely lost in loss record 2,316 of 2,342 ==382381== at 0x48F3437: g_type_create_instance (in /usr/lib64/libgobject-2.0.so.0.7000.3) ==382381== by 0x48DAD4C: ??? (in /usr/lib64/libgobject-2.0.so.0.7000.3) ==382381== by 0x48DBD1C: g_object_new_with_properties (in /usr/lib64/libgobject-2.0.so.0.7000.3) ==382381== by 0x48DC820: g_object_new (in /usr/lib64/libgobject-2.0.so.0.7000.3) ==382381== by 0x4883EED: osinfo_image_get_os_variants (osinfo_image.c:355) ==382381== by 0x402C6A: test_loaded (test-image.c:74) ==382381== by 0x4992BD5: ??? (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x49928FA: ??? (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x49930A9: g_test_run_suite (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x49930D0: g_test_run (in /usr/lib64/libglib-2.0.so.0.7000.3) ==382381== by 0x402386: main (test-image.c:114) Signed-off-by: Victor Toso --- osinfo/osinfo_image.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/osinfo/osinfo_image.c b/osinfo/osinfo_image.c index ad0c8d9..7a36b6c 100644 --- a/osinfo/osinfo_image.c +++ b/osinfo/osinfo_image.c @@ -363,7 +363,9 @@ OsinfoOsVariantList *osinfo_image_get_os_variants(OsinfoImage *image) OSINFO_LIST(os_variants), filter); } + g_object_unref(filter); g_object_unref(os_variants); + g_list_free(ids); return image_variants; } -- cgit v1.2.1