From c726cbb30cfa091f445bee3f8681fcef115b2e9d Mon Sep 17 00:00:00 2001 From: Victor Toso Date: Tue, 15 Feb 2022 21:01:04 +0100 Subject: media: Fix leak of GList * Found by covscan. 6. libosinfo-1.9.0/osinfo/osinfo_media.c:1675: alloc_fn: Storage is returned from allocation function "osinfo_entity_get_param_value_list". 7. libosinfo-1.9.0/osinfo/osinfo_media.c:1675: var_assign: Assigning: "ids" = storage returned from "osinfo_entity_get_param_value_list(OSINFO_ENTITY(media), "variant")". 8. libosinfo-1.9.0/osinfo/osinfo_media.c:1679: var_assign: Assigning: "node" = "ids". 12. libosinfo-1.9.0/osinfo/osinfo_media.c:1690: leaked_storage: Variable "ids" going out of scope leaks the storage it points to. # 1688| g_object_unref(os_variants); # 1689| # 1690|-> return media_variants; # 1691| } # 1692| Signed-off-by: Victor Toso --- osinfo/osinfo_media.c | 1 + 1 file changed, 1 insertion(+) diff --git a/osinfo/osinfo_media.c b/osinfo/osinfo_media.c index 4e3c02c..598864a 100644 --- a/osinfo/osinfo_media.c +++ b/osinfo/osinfo_media.c @@ -1690,6 +1690,7 @@ OsinfoOsVariantList *osinfo_media_get_os_variants(OsinfoMedia *media) filter); } g_object_unref(os_variants); + g_list_free(ids); return media_variants; } -- cgit v1.2.1