Add a PCAP_DEPRECATED attribute, and apply it to pcap_lookupdev().

It's not thread-safe, and it behaves weirdly on Windows.

1 files changed, 7 insertions, 0 deletions

diff --git a/pcap/pcap.h b/pcap/pcap.h
index 2a6e007d..fd2ed171 100644
--- a/pcap/pcap.h
+++ b/pcap/pcap.h
@@ -310,7 +310,14 @@ typedef void (*pcap_handler)(u_char *, const struct pcap_pkthdr *,
  */
 #define PCAP_NETMASK_UNKNOWN	0xffffffff
 
+/*
+ * We're deprecating pcap_lookupdev() for various reasons (not
+ * thread-safe, can behave weirdly with WinPcap).  Callers
+ * should use pcap_findalldevs() and use the first device.
+ */
+PCAP_DEPRECATED("use 'pcap_findalldevs' and use the first device")
 PCAP_API char	*pcap_lookupdev(char *);
+
 PCAP_API int	pcap_lookupnet(const char *, bpf_u_int32 *, bpf_u_int32 *, char *);
 
 PCAP_API pcap_t	*pcap_create(const char *, char *);