diff options
| author | npmccallum <npmccallum@c587cffe-e639-0410-9787-d7902ae8ed56> | 2007-12-12 23:47:24 +0000 |
|---|---|---|
| committer | npmccallum <npmccallum@c587cffe-e639-0410-9787-d7902ae8ed56> | 2007-12-12 23:47:24 +0000 |
| commit | 9fc92bd06846d275ca0813685cf10b542991f119 (patch) | |
| tree | c2f7220aaf9fcf58c66b934c14b618e556c26a01 | |
| parent | f9d7e790dcab50ef9881874ffc9511927a3aef9b (diff) | |
| download | libproxy-git-9fc92bd06846d275ca0813685cf10b542991f119.tar.gz | |
found the bottleneck... its where we shell out for xlsclients. Added a TODO to fix this.
| -rw-r--r-- | src/plugins/gnome.c | 1 | ||||
| -rw-r--r-- | src/plugins/kde.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/plugins/gnome.c b/src/plugins/gnome.c index e1e5576..9ea44c8 100644 --- a/src/plugins/gnome.c +++ b/src/plugins/gnome.c @@ -121,6 +121,7 @@ gconf_on_get_proxy(pxProxyFactory *self) { // If we are running in GNOME, then make sure this plugin is registered. // Otherwise, make sure this plugin is NOT registered. + // TODO: Don't shell out... this is a MAJOR performance bottleneck if (!system("xlsclients 2>/dev/null | grep -q -E '[\t ]gnome-(session|panel)$'")) px_proxy_factory_config_add(self, "gnome", PX_CONFIG_CATEGORY_SESSION, (pxProxyFactoryPtrCallback) gconf_config_cb); diff --git a/src/plugins/kde.c b/src/plugins/kde.c index 921d9fd..fac2c39 100644 --- a/src/plugins/kde.c +++ b/src/plugins/kde.c @@ -85,6 +85,7 @@ kde_on_get_proxy(pxProxyFactory *self) { // If we are running in KDE, then make sure this plugin is registered. // Otherwise, make sure this plugin is NOT registered. + // TODO: Don't shell out... this is a MAJOR performance bottleneck if (!system("xlsclients 2>/dev/null | grep -q '[\t ]kicker$'")) px_proxy_factory_config_add(self, "kde", PX_CONFIG_CATEGORY_SESSION, (pxProxyFactoryPtrCallback) kde_config_cb); |