arch: removed unnecessary call in `seccomp_add_arch`.

Some logic in the implementation of `seccomp_add_arch` can never
be reached and `arch_def_lookup` was called redundantly.

Signed-off-by: Jiannan Guo <guojiannan1101@gmail.com>
[PM: update subject line]
Signed-off-by: Paul Moore <paul@paul-moore.com>

1 files changed, 2 insertions, 4 deletions

diff --git a/src/api.c b/src/api.c
index 7d5b1ec..7ccb9f6 100644
--- a/src/api.c
+++ b/src/api.c
@@ -168,14 +168,12 @@ API int seccomp_arch_add(scmp_filter_ctx ctx, uint32_t arch_token)
 	if (arch_token == 0)
 		arch_token = arch_def_native->token;
 
-	if (arch_valid(arch_token))
+	arch = arch_def_lookup(arch_token);
+	if (arch == NULL)
 		return -EINVAL;
 	if (db_col_arch_exist(col, arch_token))
 		return -EEXIST;
 
-	arch = arch_def_lookup(arch_token);
-	if (arch == NULL)
-		return -EFAULT;
 	return db_col_db_new(col, arch);
 }