From 713cc03591eb21d36e56f14a1db85ad084b92d03 Mon Sep 17 00:00:00 2001 From: Brian Cain Date: Wed, 6 May 2015 15:34:38 -0400 Subject: tests: fixed leak in basic-resolver seccomp_syscall_resolve_num_arch() returns a string from strdup() that needs to be reaped. I found this bug using clang and address-sanitizer. Signed-off-by: Brian Cain Signed-off-by: Paul Moore (imported from commit 5b813a7331dcadd5d8b63532df8d07cdf47a041e) --- tests/15-basic-resolver.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/tests/15-basic-resolver.c b/tests/15-basic-resolver.c index a8988fd..0bd0cf8 100644 --- a/tests/15-basic-resolver.c +++ b/tests/15-basic-resolver.c @@ -21,40 +21,51 @@ #include #include +#include #include int main(int argc, char *argv[]) { - char *name; + char *name = NULL; if (seccomp_syscall_resolve_name("open") != __NR_open) - return 1; + goto fail; if (seccomp_syscall_resolve_name("socket") != __NR_socket) - return 1; + goto fail; if (seccomp_syscall_resolve_name("INVALID") != __NR_SCMP_ERROR) - return 1; + goto fail; if (seccomp_syscall_resolve_name_arch(SCMP_ARCH_NATIVE, "open") != __NR_open) - return 1; + goto fail; if (seccomp_syscall_resolve_name_arch(SCMP_ARCH_NATIVE, "socket") != __NR_socket) - return 1; + goto fail; if (seccomp_syscall_resolve_name_arch(SCMP_ARCH_NATIVE, "INVALID") != __NR_SCMP_ERROR) - return 1; + goto fail; name = seccomp_syscall_resolve_num_arch(SCMP_ARCH_NATIVE, __NR_open); if (name == NULL || strcmp(name, "open") != 0) - return 1; + goto fail; + free(name); + name = seccomp_syscall_resolve_num_arch(SCMP_ARCH_NATIVE, __NR_socket); if (name == NULL || strcmp(name, "socket") != 0) - return 1; + goto fail; + free(name); + name = seccomp_syscall_resolve_num_arch(SCMP_ARCH_NATIVE, __NR_SCMP_ERROR); if (name != NULL) - return 1; + goto fail; + free(name); return 0; + +fail: + if (name != NULL) + free(name); + return 1; } -- cgit v1.2.1