From 94f684f858673365c8dc103affe54de698f63421 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Wed, 31 Aug 2022 10:34:39 -0700 Subject: arch: disambiguate $(( in arch-syscall-validate shellcheck complains: > In arch-syscall-validate line 785: > sc_list=$((for abi in $abi_list; do > ^-- SC1102 (error): Shells disambiguate $(( differently or not at all. For $(command substitution), add space after $( . For $((arithmetics)), fix parsing errors. Another tool, shfmt, can't even parse the file: > arch-syscall-validate:785:17: not a valid arithmetic operator: abi Add a space to resolve this. Signed-off-by: Kir Kolyshkin Acked-by: Paul Moore Signed-off-by: Tom Hromatka --- src/arch-syscall-validate | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arch-syscall-validate b/src/arch-syscall-validate index 082ac56..0cb4d8f 100755 --- a/src/arch-syscall-validate +++ b/src/arch-syscall-validate @@ -782,9 +782,9 @@ function gen_csv() { eval output_$abi=$(mktemp -t syscall_validate_XXXXXX) dump_$2_$abi "$1" > $(eval echo $`eval echo output_$abi`) done - sc_list=$((for abi in $abi_list; do + sc_list=$( (for abi in $abi_list; do cat $(eval echo $`eval echo output_$abi`); - done) | awk -F "," '{ print $1 }' | sort -u) + done) | awk -F "," '{ print $1 }' | sort -u) # redirect the subshell to the csv file ( -- cgit v1.2.1