diff options
| author | Dan Winship <danw@gnome.org> | 2015-01-02 09:02:05 -0500 |
|---|---|---|
| committer | Dan Winship <danw@gnome.org> | 2015-01-02 09:02:05 -0500 |
| commit | a3d6fea00b9f27cd89495a6399e5fcc99e30af10 (patch) | |
| tree | fb8cf05a36aa110e7f3c22da9b5d19e245ff23a9 | |
| parent | 43fe2259a1c940acc8c38fdcca2cd927968a1fef (diff) | |
| download | libsoup-a3d6fea00b9f27cd89495a6399e5fcc99e30af10.tar.gz | |
tests: fix bug in checking for a bug in xmlrpc-test
When porting to gtestutils, the check for "PHP is buggy" in
xmlrpc-test got messed up so that it triggered even when PHP wasn't
buggy, causing the test to get labelled as "skipped".
Since the PHP bug in question (https://bugs.php.net/45996) was fixed
years ago anyway, just remove the workaround for it.
| -rw-r--r-- | tests/xmlrpc-test.c | 16 |
1 files changed, 1 insertions, 15 deletions
diff --git a/tests/xmlrpc-test.c b/tests/xmlrpc-test.c index f6b20b8f..cf9cb917 100644 --- a/tests/xmlrpc-test.c +++ b/tests/xmlrpc-test.c @@ -327,13 +327,6 @@ static const char *const echo_strings[] = { }; #define N_ECHO_STRINGS G_N_ELEMENTS (echo_strings) -static const char *const echo_strings_broken[] = { - "This is a test", - " so is this", - "and so is this", - "amp; so is lt;thisgt;" -}; - static void test_echo (void) { @@ -371,15 +364,8 @@ test_echo (void) g_assert_cmpint (echoes->n_values, ==, N_ECHO_STRINGS); - for (i = 0; i < echoes->n_values; i++) { - if (!server_test && strcmp (echo_strings_broken[i], g_value_get_string (&echoes->values[i])) == 0) { - g_test_skip ("PHP bug"); - g_value_array_free (echoes); - return; - } - + for (i = 0; i < echoes->n_values; i++) g_assert_cmpstr (echo_strings[i], ==, g_value_get_string (&echoes->values[i])); - } g_value_array_free (echoes); } |