diff options
| author | bfriesen <bfriesen> | 2014-12-06 20:36:14 +0000 |
|---|---|---|
| committer | bfriesen <bfriesen> | 2014-12-06 20:36:14 +0000 |
| commit | 704c212ff62863b2772e77f75117bd6406c1ed56 (patch) | |
| tree | 25ebf279490e004b6fbe1b88ea1c08c59fc6a0bd | |
| parent | b0b935721016c5ee25116e83a3c1a8ba54d4c7c2 (diff) | |
| download | libtiff-704c212ff62863b2772e77f75117bd6406c1ed56.tar.gz | |
Update the valgrind memcheck recipe for the test suite.
| -rw-r--r-- | test/Makefile.am | 17 | ||||
| -rw-r--r-- | test/Makefile.in | 17 |
2 files changed, 30 insertions, 4 deletions
diff --git a/test/Makefile.am b/test/Makefile.am index 4e115c95..da8e37b8 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -184,9 +184,22 @@ custom_dir_LDADD = $(LIBTIFF) AM_CPPFLAGS = -I$(top_srcdir)/libtiff -# memcheck: valgrind's memory access checker +# memcheck: valgrind's memory access checker. +# +# The suppressions which come with valgrind are sometimes insufficient +# to handle certain system library aspects which may be reported and +# which are unrelated to libtiff. When first starting with a new +# system (or after a major system update), it is good to execute the +# test suite (known to already be passing!) like 'make memcheck +# VALGRIND_EXTRA_OPTS=--gen-suppressions=all' to create valgrind +# suppression entries in the test log. Make sure that none of the +# suppressions are due to libtiff itself. Tell valgrind about the +# suppressions by creating a .valgrindrc file with content like: +# --memcheck:suppressions=mysupp.supp memcheck: - $(MAKE) MEMCHECK='valgrind --tool=memcheck --leak-check=full --read-var-info=yes --track-origins=yes --num-callers=12 --quiet $(VALGRIND_EXTRA_OPTS)' check + $(MAKE) MEMCHECK='valgrind --tool=memcheck --leak-check=full --read-var-info=yes \ + --error-exitcode=2 --track-origins=yes --num-callers=12 \ + --quiet $(VALGRIND_EXTRA_OPTS)' check # ptrcheck: valgrind's experimental pointer checking tool. ptrcheck: diff --git a/test/Makefile.in b/test/Makefile.in index 262e4f1b..3cdab31a 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -1731,9 +1731,22 @@ uninstall-am: recheck tags uninstall uninstall-am -# memcheck: valgrind's memory access checker +# memcheck: valgrind's memory access checker. +# +# The suppressions which come with valgrind are sometimes insufficient +# to handle certain system library aspects which may be reported and +# which are unrelated to libtiff. When first starting with a new +# system (or after a major system update), it is good to execute the +# test suite (known to already be passing!) like 'make memcheck +# VALGRIND_EXTRA_OPTS=--gen-suppressions=all' to create valgrind +# suppression entries in the test log. Make sure that none of the +# suppressions are due to libtiff itself. Tell valgrind about the +# suppressions by creating a .valgrindrc file with content like: +# --memcheck:suppressions=mysupp.supp memcheck: - $(MAKE) MEMCHECK='valgrind --tool=memcheck --leak-check=full --read-var-info=yes --track-origins=yes --num-callers=12 --quiet $(VALGRIND_EXTRA_OPTS)' check + $(MAKE) MEMCHECK='valgrind --tool=memcheck --leak-check=full --read-var-info=yes \ + --error-exitcode=2 --track-origins=yes --num-callers=12 \ + --quiet $(VALGRIND_EXTRA_OPTS)' check # ptrcheck: valgrind's experimental pointer checking tool. ptrcheck: |