summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* * libtiff 4.0.7 released.Release-v4-0-7bfriesen2016-11-1911-27/+45
| | | | * configure.ac: Update for 4.0.7 release.
* * tools/tiffdump.c (ReadDirectory): Remove uint32 cast tobfriesen2016-11-192-7/+13
| | | | | _TIFFmalloc() argument which resulted in Coverity report. Added more mutiplication overflow checks.
* Assign CVE numberserouault2016-11-191-2/+2
|
* * tools/tiffcrop.c: Fix memory leak in (recent) error code path.erouault2016-11-182-1/+7
| | | | Fixes Coverity 1394415.
* Cast away unused return value from snprintf() to possibly eliminate a ↵bfriesen2016-11-181-2/+2
| | | | compilation warning.
* * libtiff/tif_getimage.c: Fix some benign warnings which appear inbfriesen2016-11-182-5/+13
| | | | | | | 64-bit compilation under Microsoft Visual Studio of the form "Arithmetic overflow: 32-bit value is shifted, then cast to 64-bit value. Results might not be an expected value.". Problem was reported on November 16, 2016 on the tiff mailing list.
* * libtiff/tif_dirread.c: in TIFFFetchNormalTag(), do not dereferenceerouault2016-11-162-3/+12
| | | | | | | | NULL pointer when values of tags with TIFF_SETGET_C16_ASCII / TIFF_SETGET_C32_ASCII access are 0-byte arrays. Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2593 (regression introduced by previous fix done on 2016-11-11 for CVE-2016-9297). Reported by Henri Salo.
* Assign CVE-2016-9297 numbererouault2016-11-141-1/+1
|
* Move mis-classified change note.bfriesen2016-11-121-7/+7
|
* * tools/tiffinfo.c (TIFFReadContigTileData): Fix signed/unsignedbfriesen2016-11-122-6/+11
| | | | | | comparison warning. (TIFFReadSeparateTileData): Fix signed/unsigned comparison warning.
* tmsize_t is a signed type so change casting to cast to unsigned type before ↵bfriesen2016-11-121-2/+2
| | | | compare
* * tools/tiffcrop.c (readContigTilesIntoBuffer): Fixbfriesen2016-11-122-2/+5
| | | | signed/unsigned comparison warning.
* * html/v4.0.7.html: Add a file to document the pending 4.0.7bfriesen2016-11-122-0/+404
| | | | release.
* Fix typo in commenterouault2016-11-121-2/+2
|
* Fix typo in commenterouault2016-11-111-2/+2
|
* * tools/tiff2pdf.c: avoid undefined behaviour related to overlappingerouault2016-11-112-2/+14
| | | | | | of source and destination buffer in memcpy() call in t2p_sample_rgbaa_to_rgb() Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2577
* * tools/tiff2pdf.c: fix potential integer overflows on 32 bit buildserouault2016-11-112-1/+15
| | | | | in t2p_read_tiff_size() Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2576
* Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2587 (CVE-2016-9273)erouault2016-11-111-1/+1
|
* * libtiff/tif_aux.c: fix crash in TIFFVGetFieldDefaulted()erouault2016-11-112-6/+20
| | | | | | when requesting Predictor tag and that the zip/lzw codec is not configured. Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2591
* * libtiff/tif_dirread.c: in TIFFFetchNormalTag(), make sure thaterouault2016-11-112-1/+19
| | | | | | | values of tags with TIFF_SETGET_C16_ASCII / TIFF_SETGET_C32_ASCII access are null terminated, to avoid potential read outside buffer in _TIFFPrintField(). Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2590
* * libtiff/tif_dirread.c: reject images with OJPEG compression thaterouault2016-11-112-2/+13
| | | | | | | have no TileOffsets/StripOffsets tag, when OJPEG compression is disabled. Prevent null pointer dereference in TIFFReadRawStrip1() and other functions that expect td_stripbytecount to be non NULL. Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2585
* * tools/tiffcrop.c: fix multiple uint32 overflows inerouault2016-11-112-5/+49
| | | | | | | writeBufferToSeparateStrips(), writeBufferToContigTiles() and writeBufferToSeparateTiles() that could cause heap buffer overflows. Reported by Henri Salo from Nixu Corporation. Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2592
* * libtiff/tif_strip.c: make TIFFNumberOfStrips() return the td->td_nstripserouault2016-11-092-1/+18
| | | | | | | value when it is non-zero, instead of recomputing it. This is needed in TIFF_STRIPCHOP mode where td_nstrips is modified. Fixes a read outsize of array in tiffsplit (or other utilities using TIFFNumberOfStrips()). Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2587
* * libtiff/tif_predic.c: fix memory leaks in error code paths added inerouault2016-11-042-3/+12
| | | | previous commit (fix for MSVR 35105)
* * libtiff/tif_predict.h, libtiff/tif_predict.c:erouault2016-10-313-49/+123
| | | | | | | | Replace assertions by runtime checks to avoid assertions in debug mode, or buffer overflows in release mode. Can happen when dealing with unusual tile size like YCbCr with subsampling. Reported as MSVR 35105 by Axel Souchet & Vishal Chauhan from the MSRC Vulnerabilities & Mitigations team.
* * tools/fax2tiff.c: fix segfault when specifying -r withouterouault2016-10-252-2/+8
| | | | | argument. Patch by Yuriy M. Kaminskiy. Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2572
* Fixing last ChangeLog entryerouault2016-10-251-1/+1
|
* * libtiff/tif_dir.c: discard values of SMinSampleValue anderouault2016-10-253-4/+57
| | | | | | | | | | | | | | | | | | SMaxSampleValue when they have been read and the value of SamplesPerPixel is changed afterwards (like when reading a OJPEG compressed image with a missing SamplesPerPixel tag, and whose photometric is RGB or YCbCr, forcing SamplesPerPixel being 3). Otherwise when rewriting the directory (for example with tiffset, we will expect 3 values whereas the array had been allocated with just one), thus causing a out of bound read access. Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2500 (CVE-2014-8127, duplicate: CVE-2016-3658) * libtiff/tif_write.c: avoid null pointer dereference on td_stripoffset when writing directory, if FIELD_STRIPOFFSETS was artificially set for a hack case in OJPEG case. Fixes http://bugzilla.maptools.org/show_bug.cgi?id=2500 (CVE-2014-8127, duplicate: CVE-2016-3658)
* * tools/tiffinfo.c: fix out-of-bound read on some tiled images.erouault2016-10-253-7/+30
| | | | | | | | (http://bugzilla.maptools.org/show_bug.cgi?id=2517) * libtiff/tif_compress.c: make TIFFNoDecode() return 0 to indicate an error and make upper level read routines treat it accordingly. (linked to the test case of http://bugzilla.maptools.org/show_bug.cgi?id=2517)
* * tools/tiffcrop.c: fix out-of-bound read of up to 3 bytes inerouault2016-10-142-2/+17
| | | | | readContigTilesIntoBuffer(). Reported as MSVR 35092 by Axel Souchet & Vishal Chauhan from the MSRC Vulnerabilities & Mitigations team.
* * tools/tiff2pdf.c: fix write buffer overflow of 2 bytes on JPEGerouault2016-10-092-8/+18
| | | | | | compressed images. Reported by Tyler Bohan of Cisco Talos as TALOS-CAN-0187 / CVE-2016-5652. Also prevents writing 2 extra uninitialized bytes to the file stream.
* * tools/tiffcp.c: fix out-of-bounds write on tiled images with odderouault2016-10-082-3/+10
| | | | | | tile width vs image width. Reported as MSVR 35103 by Axel Souchet and Vishal Chauhan from the MSRC Vulnerabilities & Mitigations team.
* * tools/tiff2pdf.c: fix read -largely- outsize of buffer inerouault2016-10-082-3/+11
| | | | | | | t2p_readwrite_pdf_image_tile(), causing crash, when reading a JPEG compressed image with TIFFTAG_JPEGTABLES length being one. Reported as MSVR 35101 by Axel Souchet and Vishal Chauhan from the MSRC Vulnerabilities & Mitigations team.
* * tools/tiffcp.c: fix read of undefined variable in case of missingerouault2016-10-083-7/+19
| | | | | | | | required tags. Found on test case of MSVR 35100. * tools/tiffcrop.c: fix read of undefined buffer in readContigStripsIntoBuffer() due to uint16 overflow. Probably not a security issue but I can be wrong. Reported as MSVR 35100 by Axel Souchet from the MSRC Vulnerabilities & Mitigations team.
* * html: Change as many remotesensing.org broken links to a workingbfriesen2016-09-25182-379/+382
| | | | URL as possible.
* * libtiff/tif_getimage.c (TIFFRGBAImageOK): Reject attempts tobfriesen2016-09-243-22/+42
| | | | | | | | | | read floating point images. * libtiff/tif_predict.c (PredictorSetup): Enforce bits-per-sample requirements of floating point predictor (3). Fixes CVE-2016-3622 "Divide By Zero in the tiff2rgba tool." places where it isn't done currently, but it seems this patch is enough.
* * tools/tiffcrop.c: fix various out-of-bounds write vulnerabilitieserouault2016-09-235-39/+96
| | | | | | | | | | | | | | | | | | | | | | in heap or stack allocated buffers. Reported as MSVR 35093, MSVR 35096 and MSVR 35097. Discovered by Axel Souchet and Vishal Chauhan from the MSRC Vulnerabilities & Mitigations team. * tools/tiff2pdf.c: fix out-of-bounds write vulnerabilities in heap allocate buffer in t2p_process_jpeg_strip(). Reported as MSVR 35098. Discovered by Axel Souchet and Vishal Chauhan from the MSRC Vulnerabilities & Mitigations team. * libtiff/tif_pixarlog.c: fix out-of-bounds write vulnerabilities in heap allocated buffers. Reported as MSVR 35094. Discovered by Axel Souchet and Vishal Chauhan from the MSRC Vulnerabilities & Mitigations team. * libtiff/tif_write.c: fix issue in error code path of TIFFFlushData1() that didn't reset the tif_rawcc and tif_rawcp members. I'm not completely sure if that could happen in practice outside of the odd behaviour of t2p_seekproc() of tiff2pdf). The report points that a better fix could be to check the return value of TIFFFlushData1() in places where it isn't done currently, but it seems this patch is enough. Reported as MSVR 35095. Discovered by Axel Souchet & Vishal Chauhan & Suha Can from the MSRC Vulnerabilities & Mitigations team.
* * html/man/index.html: Comment out links to documentation forbfriesen2016-09-202-4/+9
| | | | abandoned utilities.
* * libtiff/tif_lzma.c: typo fix in commenterouault2016-09-172-2/+6
|
* * libtiff/*.c: fix warnings raised by clang 3.9 -Wcommaerouault2016-09-0412-92/+205
|
* * libtiff/tif_dirwrite.c, libtiff/tif_color.c: fix warnings raisederouault2016-09-032-3/+4
| | | | by GCC 5 / clang -Wfloat-conversion
* * libtiff/tif_dirwrite.c: fix warnings raised by GCC 5 -Wfloat-conversionerouault2016-09-022-7/+11
|
* * tools/tiffcrop.c: fix C99'ism.erouault2016-08-162-2/+6
|
* * tools/tiff2bw.c: fix weight computation that could result of colorerouault2016-08-152-2/+8
| | | | | value overflow (no security implication). Fix bugzilla #2550. Patch by Frank Freudenberg.
* Fix signed vs unsigned comparisonerouault2016-08-151-2/+2
|
* * tools/rgb2ycbcr.c: validate values of -v and -h parameters toerouault2016-08-152-1/+10
| | | | avoid potential divide by zero. Fixes CVE-2016-3623 (bugzilla #2569)
* * tools/tiffcrop.c: Fix out-of-bounds write in loadImage().erouault2016-08-152-4/+63
| | | | | From patch libtiff-CVE-2016-3991.patch from libtiff-4.0.3-25.el7_2.src.rpm by Nikola Forro (bugzilla #2543)
* * libtiff/tif_pixarlog.c: Fix write buffer overflow in PixarLogEncodeerouault2016-08-152-2/+17
| | | | | | | | | | if more input samples are provided than expected by PixarLogSetupEncode. Idea based on libtiff-CVE-2016-3990.patch from libtiff-4.0.3-25.el7_2.src.rpm by Nikola Forro, but with different and simpler check. (bugzilla #2544) invalid tests that rejected valid files. (bugzilla #2545)
* * tools/tiff2rgba.c: Fix integer overflow in size of allocatederouault2016-08-152-5/+39
| | | | | | | buffer, when -b mode is enabled, that could result in out-of-bounds write. Based initially on patch tiff-CVE-2016-3945.patch from libtiff-4.0.3-25.el7_2.src.rpm by Nikola Forro, with correction for invalid tests that rejected valid files.
* (CVE-2016-5321 / CVE-2016-5323 , bugzilla #2558 / #2559)erouault2016-07-112-10/+10
|