summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* libtoolize: refactor copying filter creation.Gary V. Vaughan2011-12-081-75/+86
| | | | | | | | | | | | | | | Prevent the various require_filter functions from becoming too long by factoring common code into new functions. * libtoolize (func_make_relative_dir_filter) (func_make_relative_ltdl_filter): New functions. Generalize and consolidate the various similar snippets for concatenating together the sed scripts for func_copy filtering. (require_filter_Makefile_am, require_filter_aclocal_m4) (require_filter_configure_ac): Simplify. (require_ltdl_relative_aux_dir): Remove. (require_ltdl_relative_macro_dir): Ditto. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* maint: pick XSI funcs at runtime, not configure time.Gary V. Vaughan2011-12-086-223/+281
| | | | | | | | | | | | | | | | | | | | | | | | | Determine, on a function by function basis, what XSI features are available in the shell that is actually running the script, rather than the one that was picked at configure time by the re-execution engine. * m4/libtool.m4 (_LT_PROG_FUNCTION_REPLACE) (_LT_PROG_REPLACE_SHELLFNS): Remove. (_LT_CHECK_SHELL_FEATURES): Remove tests for XSI and += support. * build-aux/general.m4sh (func_append, func_append_quoted) (func_arith, func_len, func_basename, func_dirname) (func_dirname_and_basename, func_stripname): List both enhanced and fallback implementations, and choose one based on whether the enhanced features required by the fastest version are available. * build-aux/getopt.m4sh (func_split_short_opt) (func_split_long_opt): Ditto. * build-aux/ltmain.m4sh (func_lo2o, func_xform): Ditto. * tests/getopt-m4sh.at: Add tests for enhanced and fallback implementations of func_arith, func_len, func_stripname and func_dirname_and_basename. * NEWS: Updated. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* maint: share useful functions from general.m4sh.Gary V. Vaughan2011-12-083-49/+38
| | | | | | | | | | | | | | * build-aux/ltmain.m4sh (func_append, func_append_quoted) (func_arith, func_len): Removed from here... * build-aux/general.m4sh (func_append, func_append_quoted) (func_arith, func_len): ...and added to here. (func_dirname, func_dirname_and_basename, func_normal_abspath) (func_relative_path): Use func_append. * tests/getopt-m4sh.at (_LT_AT_FALLBACK_FUNC_EXTRACT): Removed. Fallback functions are now in any m4sh generated file automatically. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* libtoolize: reorder function definitions to keep func_filter_* together.Gary V. Vaughan2011-12-081-121/+121
| | | | | | | * libtoolize: Restore asciibetical order, so that all the filter function definitions are together. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* libtoolize: use _filter as a prefix for better ordering.Gary V. Vaughan2011-12-081-36/+36
| | | | | | | | | | | | | | | * libtoolize.m4sh (require_Makefile_am_filter) (require_ltdl_mk_filter, require_aclocal_m4_filter) (require_configure_ac_filter): Rename these functions from this... (require_filter_Makefile_am, require_filter_ltdl_mk) (require_filter_aclocal_m4, require_filter_configure_ac): ...to this, respectively. Adjust all callers. (Makefile_am_filter, ltdl_mk_filter, aclocal_m4_filter) (configure_ac_filter): Rename these global variables from this... (filter_Makefile_am, filter_ltdl_mk, filter_aclocal_m4) (filter_configure_ac): ...to this, respectively. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* libtoolize: rename ltdl.mk filter function.Gary V. Vaughan2011-12-081-11/+11
| | | | | | | | * libtoolize.m4sh (require_Makefile_inc_filter): Rename from this... (require_ltdl_mk_filter): ...to this. Adjust all callers. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* bootstrap: escape quotes properly in generated functions.Gary V. Vaughan2011-12-081-1/+1
| | | | | | | | * bootstrap: Although not a real bug, for consistency, be sure to correctly escape single quotes inside a single quoted function generator. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* bootstrap: reorder function definitions to keep func_buildreq_* together.Gary V. Vaughan2011-12-081-126/+126
| | | | | | | * bootstrap: Restore asciibetical order, so that all the buildreq function definitions are together. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* bootstrap: use _buildreq as a prefix for better ordering.Gary V. Vaughan2011-12-081-22/+22
| | | | | | | | | | | | | * bootstrap (require_autobuild_buildreq) (require_autoconf_buildreq, require_automake_buildreq) (require_autopoint_buildreq, require_libtoolize_buildreq) (require_patch_buildreq): Rename from these... (require_buildreq_autobuild, require_buildreq_autoconf) (require_buildreq_automake, require_buildreq_autopoint) (require_buildreq_libtoolize, require_buildreq_patch): ...to these, respectively. Adjust all callers. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* bootstrap: ensure consistent function header comments.Gary V. Vaughan2011-12-081-4/+4
| | | | | | | | | * bootstrap (require_bootstrap_uptodate) (require_buildtools_uptodate): Use `require_...' in header comment for these functions to be consistent with the rest, rather than `func_require_...'. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* bootstrap: make sure patch is available to bootstrap if necessary.Gary V. Vaughan2011-12-081-0/+55
| | | | | | | | | | | | | | | | | | Make sure we're not lacking any functionality provided by the incumbent gnulib bootstrap script, and where it's easy to do so (like it is here), provide better functionality! * bootstrap (require_patch): Make sure that PATCH expands to the best `patch' command available on the system, honouring overrides in the users environment. (require_patch_buildreq): Automatically add a requirement for a patch command to buildreq when there are diff files in $local_gl_dir. (func_require_buildtools_uptodate): Call require_patch_buildreq before testing build tool versions. (func_gnulib_tool_copy_file): Make sure PATCH is set before using gnulib-tool to copy files. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* m4: fix logic error leading to -fno-rtti being added wrongly.Gary V. Vaughan2011-11-261-1/+1
| | | | | | | * m4/libtool.m4 (_LT_COMPILER_OPTION): Negate comparison so that compiler flags are added correctly. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* maint: Fix generated ChangeLog typos.Gary V. Vaughan2011-11-261-0/+19
| | | | | | | | * build-aux/git-log-fix: Spell Stefano Lattarini's name correctly. Don't use my home email address for GNU commits. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and implement sc_prohibit_sed_s_comma.Gary V. Vaughan2011-11-2525-155/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | I like to name temporary directories that I will remove shortly with two leading commas so that they sort lexicographically at the top of `ls' output. Now, `./configure --prefix=`pwd`/,,inst' works again, for the first time in several years. * cfg.mk (sc_prohibit_sed_s_comma): Comma is too common a character to use routinely as the separator for sed substitutions on file paths and other variables determined by the user, causing bugs like the one I describe above. Make sure we don't accidentally reintroduce any comma separators in future. * Makefile.am, bootstrap, bootstrap.conf, build-aux/extract-trace, build-aux/general.m4sh, build-aux/git-hooks/commit-msg, build-aux/git-log-fix, build-aux/ltmain.m4sh, libtoolize.m4sh, m4/libtool.m4, m4/ltdl.m4, tests/cdemo-undef.test, tests/cmdline_wrap.at, tests/darwin.at, tests/defs.m4sh, tests/getopt-m4sh.at, tests/install.at, tests/libtoolize.at, tests/mdemo/Makefile.am, tests/need_lib_prefix.at, tests/sysroot.at, tests/tagdemo-undef.test, tests/testsuite.at: Try to use `|' as the default separator wherever possible, otherwise something else that doesn't occur in the substitution expression. * NEWS: Updated. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and implement sc_prohibit_test_const_follows_var.Gary V. Vaughan2011-11-2538-643/+649
| | | | | | | | | | | | | | | | | | | | | | | | | To safely use a non-literal first argument to `test', you must always prepend a literal non-`-' character, but often the second operand is a constant that doesn't begin with a `-' already, so always use `test a = "$b"' instead of noisy `test "X$b" = Xa'. * cfg.mk (sc_prohibit_test_const_follows_var): New syntax-check rule to ensure we don't reintroduce noisy test operands. * bootstrap, build-aux/extract-trace, build-aux/general.m4sh, build-aux/ltmain.m4sh, doc/libtool.texi, libtoolize.m4sh, m4/argz.m4, m4/libtool.m4, m4/ltdl.m4, tests/bindir.at, tests/defs.m4sh, tests/demo-relink.test, tests/demo/configure.ac, tests/depdemo-relink.test, tests/destdir.at, tests/duplicate_conv.at, tests/fail.at, tests/getopt-m4sh.at, tests/help.at, tests/libtoolize.at, tests/link-2.test, tests/link-order2.at, tests/lt_dlopenext.at, tests/mdemo/configure.ac, tests/mdemo2/configure.ac, tests/need_lib_prefix.at, tests/nocase.at, tests/pdemo/configure.ac, tests/pic_flag.at, tests/search-path.at, tests/shlibpath.at, tests/static.at, tests/sysroot.at, tests/tagtrace.test, tests/testsuite.at, tests/with-pic.at: Swap operands to avoid useless noise. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and implement sc_useless_braces_in_variable_derefs.Gary V. Vaughan2011-11-2518-477/+483
| | | | | | | | | | | | | | | | | | | Until now, libtool sources have used braced variable names seemingly at random! Almost always the braces are just noise, so remove all the unnecessary ones. * cfg.mk (sc_useless_braces_in_variable_derefs): New syntax check rule to ensure we only reintroduce braced variable dereferences if they are followed by a valid variable name character. build-aux/general.m4sh, build-aux/git-hooks/commit-msg, build-aux/ltmain.m4sh, build-aux/options-parser, configure.ac, libltdl/configure.ac, m4/libtool.m4, m4/ltdl.m4, m4/ltoptions.m4, tests/defs.m4sh, tests/demo-nopic.test, tests/depdemo/configure.ac, tests/flags.at, tests/link.test, tests/objectlist.test, tests/quote.test, tests/static.at: Remove spurious braces. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and implement sc_prohibit_bare_basename.Gary V. Vaughan2011-11-258-11/+23
| | | | | | | | | | | | * cfg.mk (sc_prohibit_bare_basename, sc_prohibit_basename_with_sed): Make sure not to go back to using occasional `|$basename' or `|$dirname' syntax. * build-aux/git-hooks/commit-msg, build-aux/ltmain.m4sh, * build-aux/options-parser, tests/fcdemo-conf.test, * tests/fcdemo-shared.test, tests/fcdemo-static.test, * tests/libtoolize.at: Fix violations. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* tests: migrate tests/sh.test checks to syntax-checks.Gary V. Vaughan2011-11-2540-247/+217
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some modernization of the legacy testsuite. * tests/sh.test: Remove. * Makefile.am (COMMON_TESTS): Adjust. * cfg.mk (sc_libtool_m4_cc_basename, sc_prohibit_bracket_as_test) (sc_prohibit_nested_quotes, sc_prohibit_set_dummy_without_shift) (sc_prohibit_set_minus_minus, sc_prohibit_test_binary_operators) (sc_prohibit_test_dollar, sc_prohibit_test_minus_e) (sc_prohibit_test_unary_operators, sc_prohibit_test_X) (sc_prohibit_Xsed_withou_X, sc_require_function_nl_brace): Functionally identical tests to what used to be performed by sh.test, only with coverage of all files. * bootstrap, build-aux/edit-readme-alpha, build-aux/extract-trace, build-aux/getopt.m4sh, build-aux/ltmain.m4sh, configure.ac, m4/libtool.m4, m4/ltdl.m4, tests/bindir.at, tests/configure-iface.at, tests/cwrapper.at, tests/darwin.at, tests/defs.m4sh, tests/demo-hardcode.test, tests/dlloader-api.at, tests/exceptions.at, tests/getopt-m4sh.at, tests/lalib-syntax.at, tests/link-2.test, tests/link-order2.at, tests/loadlibrary.at, tests/lt_dladvise.at, tests/lt_dlexit.at, tests/lt_dlopen_a.at, tests/lt_dlopenext.at, tests/need_lib_prefix.at, tests/nonrecursive.at, tests/recursive.at, tests/resident.at, tests/standalone.at, tests/static.at, tests/stresstest.at, tests/subproject.at, tests/sysroot.at, tests/tagtrace.test, tests/testsuite.at: Fix violations of the new syntax checks. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and implement sc_useless_quotes_in_assignment.Gary V. Vaughan2011-11-2526-733/+753
| | | | | | | | | | | | | | | | | | | | | | | Contrary to popular belief, Bourne shell does not resplit RHS of assignments after expansion, so if there are no unquoted shell metacharacters or whitespace, the quotes are useless. * cfg.mk (_sc_search_regexp_or_exclude): A variation of gnulib's _sc_search_regexp that also allows individual exclusions at the site of what would otherwise match by adding a comment. (sc_useless_quotes_in_assignment): New syntax-check rule to ensure we don't reintroduce useless quoted assignments. * bootstrap, bootstrap.conf, build-aux/edit-readme-alpha, build-aux/general.m4sh, build-aux/getopt.m4sh, build-aux/ltmain.m4sh, build-aux/options-parser, configure.ac, doc/libtool.texi, libtoolize.m4sh, m4/libtool.m4, m4/ltdl.m4, m4/ltoptions.m4, tests/cwrapper.at, tests/defs.m4sh, tests/lalib-syntax.at, tests/libtoolize.at, tests/lt_dlopenext.at, tests/mdemo/configure.ac, tests/mdemo2/configure.ac, tests/need_lib_prefix.at, tests/no-executables.at, tests/quote.test, tests/suffix.test: Remove spurious quotes. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and implement sc_useless_quotes_in_case.Gary V. Vaughan2011-11-2511-22/+30
| | | | | | | | | | | | | | Contrary to popular belief, Bourne shell does not resplit case expressions after expansion, so if there are no unquoted shell metacharacters or whitespace, the quotes are useless. * cfg.mk (sc_useless_quotes_in_case): New syntax-check rule to ensure we don't reintroduce useless quoted case expressions. * build-aux/ltmain.m4sh, m4/libtool.m4, tests/bindir.at, tests/darwin.at, tests/defs.m4sh, tests/demo-hardcode.test, tests/demo-nopic.test, tests/link-2.test, tests/quote.test, tests/sysroot.at: Remove spurious quotes. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* maint: quote $file correctly in bootstrap.Gary V. Vaughan2011-11-251-3/+3
| | | | | | | | * bootstrap (func_insert_sorted_if_absent): Don't forget the double quotes, since we can't control the content of $file. Reported by Steffano Lattarini. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* build: fix a quoting bug when regenerating with bootstrap_edit.Gary V. Vaughan2011-11-251-2/+2
| | | | | | | | | * Makefile.am (m4/ltversion.m4, build-aux/ltmain.sh): The bootstrap_edit make macro already contains double quotes, so when echoing it, don't surround it with more double quotes since it is not escaped. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* dist: hook syntax-check into `make distcheck'.Gary V. Vaughan2011-11-171-0/+2
| | | | | | | | | | To make sure we don't accidentally release anything with failing syntax-checks, have `make distcheck' run the syntax-checks automatically. * Makefile.am (distcheck-hook): New rule depending on syntax-check. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: enable sc_prohibit_always_true_header_tests.Gary V. Vaughan2011-11-171-1/+0
| | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_always_true_header_tests from list of disabled checks, because it no longer flags any violations. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: enable sc_program_name.Gary V. Vaughan2011-11-171-2/+1
| | | | | | | | | * cfg.mk (local-checks-to-skip): Remove sc_program_name list of disabled checks. (exclude_file_name_regexp--sc_program_name): Don't check demo programs for use of set_program_name. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: enable sc_bindtextdomain.Gary V. Vaughan2011-11-171-2/+1
| | | | | | | | | * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain list of disabled checks. (exclude_file_name_regexp--sc_bindtextdomain): Don't check demo programs for use of bindtextdomain. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and implement sc_trailing_blank-non-rfc3676.Gary V. Vaughan2011-11-1732-85/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | * cfg.mk (local-checks-to-fix): Move sc_trailing_blank from here... (local-checks-to-skip): ...to here, because otherwise it flags valid RFC3676 signature blocks. (sc_trailing_blank-non-rfc3676): An improved sc_trailing_blank implementation that doesn't flag signature blocks as violations. * Makefile.am, bootstrap.conf, doc/PLATFORMS, libltdl/config/ltmain.m4sh, libltdl/m4/libtool.m4, libltdl/m4/lt~obsolete.m4, tests/archive-in-archive.at, tests/convenience.at, tests/darwin.at, tests/depdemo/l1/l1.c, tests/depdemo/l2/l2.c, tests/depdemo/l3/l3.c, tests/depdemo/l4/l4.c, tests/f77demo/README, tests/f77demo/cprogram.c, tests/f77demo/foof.f, tests/f77demo/foof2.f, tests/f77demo/foof3.f, tests/f77demo/fprogram.f, tests/fcdemo/README, tests/fcdemo/cprogram.c, tests/fcdemo/foof.f90, tests/fcdemo/foof2.f90, tests/fcdemo/foof3.f90, tests/fcdemo/fprogram.f90, tests/mdemo/README, tests/mdemo/main.c, tests/mdemo/mlib.c, tests/objectlist.test, tests/static.at, tests/template.at, tests/testsuite.at: Remove trailing blanks. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_useless_cpp_parens.Gary V. Vaughan2011-11-1730-190/+189
| | | | | | | | | | | | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_useless_cpp_parens from list of disabled checks. * doc/libtool.texi, libltdl/argz.c, libltdl/argz_.h, build-aux/ltmain.m4sh, libltdl/libltdl/lt__alloc.h, libltdl/libltdl/lt__dirent.h, libltdl/libltdl/lt__glibc.h, libltdl/libltdl/lt__private.h, libltdl/libltdl/lt__strl.h, libltdl/libltdl/lt_dlloader.h, libltdl/libltdl/lt_error.h, libltdl/libltdl/lt_system.h, libltdl/libltdl/slist.h, libltdl/loaders/dld_link.c, libltdl/loaders/dlopen.c, libltdl/loaders/dyld.c, libltdl/loaders/loadlibrary.c, libltdl/loaders/shl_load.c, libltdl/lt__dirent.c, libltdl/lt__strl.c, libltdl/ltdl.c, libltdl/ltdl.h, libltdl/m4/libtool.m4, tests/demo/foo.h, tests/depdemo/sysdep.h, tests/exceptions.at, tests/export.at, tests/pdemo/foo.h, tests/stresstest.at: Remove useless parens in cpp `#if defined(foo)' statements. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_space_tab.Gary V. Vaughan2011-11-1721-45/+45
| | | | | | | | | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_space_tab from list of disabled checks. (exclude_file_name_regexp--sc_space_tab): Don't flag space-tab sequences in diff files as an error. * Makefile.am, build-aux/general.m4sh, build-aux/git-hooks/commit-msg, build-aux/ltmain.m4sh, libltdl/loaders/dyld.c, libltdl/loaders/shl_load.c, libltdl/ltdl.h, libltdl/ltdl.mk, libltdl/slist.c, libtoolize.m4sh, m4/ltoptions.m4, tests/demo/dlmain.c, tests/depdemo/main.c, tests/libtoolize.at, tests/lt_dladvise.at, tests/pdemo/longer_file_name_dlmain.c, tests/sh.test, tests/static.at, tests/stresstest.at, tests/template.at: Fix space-tab sequences by reversing them in regexps, and deleting leading spaces in indentation. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq.Gary V. Vaughan2011-11-175-16/+15
| | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_undesirable_word_seq from list of disabled checks. * doc/libtool.texi, build-aux/ltmain.m4sh, libltdl/m4/libtool.m4, libtoolize.m4sh: Replace all uses of "can not" with "cannot". Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_probibit_test_minus_ao.Gary V. Vaughan2011-11-171-1/+2
| | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_probhibit_test_minus_ao from list of disabled checks. (exclude_file_name_regexp--sc_prohibit_tests_minus_ao): The matches from this syntax-check in libtool.m4 are all bogus. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_strcmp.Gary V. Vaughan2011-11-178-31/+34
| | | | | | | | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_strcmp from list of disabled checks. (exclude_file_name_regexp--sc_prohibit_strcmp): Ignore violations in libtool.texi and any demo C files. * libltdl/libltdl/lt__private.h (strneq, streq): Renamed from this... (STRNEQ, STREQ): ..to this. Adjust all callers. * tests/slist.at: Add STREQ definition. Change all !strcmp calls to STREQ. * build-aux/ltmain.m4sh (func_emit_cwrapperexe_src): Add and use STREQ definition. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_stddef_without_use.Gary V. Vaughan2011-11-174-4/+0
| | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_stddef_without_use from list of disabled checks. * libltdl/argz.c, libltdl/lt__dirent.c, libltdl/slist.c: Remove spurious stddef.h #include lines. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_magic_number_exit.Gary V. Vaughan2011-11-172-37/+0
| | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_magic_number_exit from list of disabled checks. * ltmain.c: Removed unused file. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_have_config_h.Gary V. Vaughan2011-11-173-5/+0
| | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_have_config_h from list of disabled checks. * tests/f77demo/foo.h, tests/fcdemo/foo.h: Remove spurious HAVE_CONFIG_H guards for #include <config.h>. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_empty_lines_at_EOF.Gary V. Vaughan2011-11-1712-18/+0
| | | | | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_empty_lines_at_EOF from list of disabled checks. * THANKS, libltdl/argz.c, libltdl/config/getopt.m4sh, tests/f77demo/README, tests/f77demo/cprogram.c, tests/f77demo/fprogram.f, tests/fcdemo/README, tests/fcdemo/cprogram.c, tests/libtoolize.at, tests/mdemo/README, tests/mdemo2/README, tests/pdemo-inst.test: Remove spurious empty lines from the end of these files. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_doubled_word.Gary V. Vaughan2011-11-173-4/+3
| | | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_doubled_word from list of disabled checks. * build-aux/general.m4sh (func_quote_for_eval): Remove one of a pair of "and"s in a comment. * tests/lt_dladvise.at (hint_global): Remove one of a pair of consecutive "to"s split across lines in a comment. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_prohibit_cvs_keyword.Gary V. Vaughan2011-11-172-3/+0
| | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_prohibit_cvs_keyword from list of disabled checks. * tests/tagdemo/README: Remove spurious CVS keyword. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_makefile_at_at_check.Gary V. Vaughan2011-11-174-30/+28
| | | | | | | | | | | | | | | | | | | | | | | | At some point we were supporting some undetermined `broken make', as evidenced by having carried the following code since 2003: ## use @LIBLTDL@ because some broken makes do not accept ## macros in targets, we can only do this because our LIBLTDL ## does not contain $(top_builddir). @LIBLTDL@: $(top_distdir)/libtool \ ... However, we've also had *many* cases of macros in targets for just as long, so most likely we never fully supported makes allegedly broken in this way. As of this release, we explicitly no longer support make implementations that do not accept macros in targets. * cfg.mk (local-checks-to-fix): Remove sc_makefile_at_at_check from list of disabled checks. * configure.ac (order-only prerequisites): Test with the order-only pipe symbol in a macro. * Makefile.am, tests/mdemo/Makefile.am: Convert all @FOO@ to $(FOO). Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_makefile_TAB_only_indentation.Gary V. Vaughan2011-11-173-7/+6
| | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_makefile_TAB_only_indentation from list of disabled checks. * Makefile.am (libltdl/Makefile.am): Replace leading spaces with TABs. * libltdl/Makefile.am (libltdl_libltdl_la_SOURCES): Ditto. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_m4_quote_check.Gary V. Vaughan2011-11-172-2/+1
| | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_m4_quote_check from list of disabled checks. * libltdl/m4/libtool.m4 (_LT_CHECK_OBJDIR): Quote LT_OBJDIR correctly. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_file_system.Gary V. Vaughan2011-11-174-8/+7
| | | | | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_file_system from list of disabled checks. (VC_LIST_ALWAYS_EXCLUDE_REGEX): Match mail directory correctly to avoid running its contents through syntax-check. * build-aux/ltmain.m4sh (func_mode_link): Use correct spelling for "file system". * libltdl/ltdl.c (try_dlopen): Ditto. * tests/dlloader-api.at: Ditto. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_error_message_uppercase.Gary V. Vaughan2011-11-173-4/+7
| | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_error_message_uppercase from list of disabled checks. (exclude_file_name_regexp--sc_error_message_uppercase): Don't match cvsu, which is not our file to edit. * doc/libtool.texi: Use lowercase error message in example. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: rationale for disabling sc_cast_of_x_alloc_return_value.Gary V. Vaughan2011-11-171-1/+2
| | | | | | | * cfg.mk: Note that we support C++ compilation of libltdl, which in turn requires that *alloc return values be cast correctly. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_cast_of_argument_to_free.Gary V. Vaughan2011-11-175-7/+5
| | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_cast_of_argument_to_free from list of disabled checks. * build-aux/ltmain.m4sh, libltdl/libltdl/lt__alloc.h, libltdl/lt__dirent.c: Casting argument to free is never necessary. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: fix violations and re-enable sc_avoid_if_before_free.Gary V. Vaughan2011-11-172-7/+5
| | | | | | | | | | | | | * cfg.mk (local-checks-to-fix): Remove sc_avoid_if_before_free from list of disabled checks. According to gnulib/doc/free.texi: "On old platforms such as SunOS4, @code{free (NULL)} fails. However, since all such systems are so old as to no longer be considered ``reasonable portability targets,'' this module is no longer useful." * libltdl/libltdl/lt__alloc.h (FREE, MEMREASSIGN): Don't protect against freeing NULL bug on SunOS4. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* syntax-check: skip sc_unmarked_diagnostics.Gary V. Vaughan2011-11-171-3/+4
| | | | | | | | * cfg.mk (local-checks-to-fix): Move sc_unmarked_diagnostics from here... (local-checks-to-skip): ...to here. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* libtoolize: rename `libltdl/config' directory to standard `build-aux'.Gary V. Vaughan2011-11-1730-187/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In addition to moving the autoconf auxiliary script directory into the place expected by GNU developers ($top_srcdir/build-aux) we also simplify libtoolize somewhat by having libltdl use whatever directory was specified by the parent project. This is much more flexible, allows libltdl client projects to also use a single canonical `$top_srcdir/build-aux' auxiliary script directory, and maintains backward compatibility with existing projects that wish to continue using $ltdl_dir/config. * libltdl/config: Moved whole directory from here... * build-aux: ...to here. * libtoolize.m4sh (func_install_pkgaux_subproject): Remove. (func_install_pkgaux_parent): Remove. (func_install_pkgaux_files): Considerably simplified now that we have only a single auxiliary directory to worry about. (subproject_aux_dir): Remove. * bootstrap.conf (libtool_readme_release_package_substitutions): No need to substitute our old unusual aux_dir location into README-release any more. * cfg.mk (_build-aux): Now that we use the standard location for this directory, no need to set this variable either. * configure.ac (AC_INIT): git-version-gen has moved. (AC_CONFIG_AUX_DIR): Adjust. * Makefile.am (stamp-mk, auxexefiles, auxfiles) (install-data-local): Use build-aux instead of config. (libltdl/stamp-mk): Ditto. * libltdl/configure.ac, tests/cdemo/configure.ac, tests/demo/configure.ac, tests/depdemo/configure.ac, tests/f77demo/configure.ac, tests/fcdemo/configure.ac, tests/mdemo/configure.ac, tests/mdemo2/configure.ac, tests/pdemo/configure.ac, tests/tagdemo/configure.ac (AC_CONFIG_AUX_DIR): Ditto. * tests/defs.m4sh (aux_dir): Ditto. * tests/configure-iface.at, tests/getopt-m4sh.at, tests/libtoolize.at, tests/subproject.at, tests/testsuite.at: Ditto. * Makefile.am (ltdl_ac_aux_dir): Extract at build-time... * libtoolize.m4sh (require_ltdl_ac_aux_dir): ...so that libtoolize can access it at runtime without requiring GNU M4 via the extract-trace script. (require_Makefile_am_filter): Use it to determine whether the aux_dir declared in the current (parent) project configure is compatible with the declarations in installed ltdl autotools source files. (require_configure_ac_filter): New function to perform similar checks and rewrite configure.ac during installation if necessary. * NEWS: Updated. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* libtoolize: aux scripts go in ltdl dir when parent has no configure.Gary V. Vaughan2011-11-171-5/+21
| | | | | | | | | | | | | | When using libtoolize to install subproject libltdl into a parent project that does not use autotools, set the default directory for auxiliary scripts inside libltdl rather than littering the parent project with files it doesn't use. * libtoolize.m4sh (func_require_ac_aux_dir): In verbose mode, report results like other require_ funcs. (func_require_aux_dir): Put subproject auxiliary files into ltdl directory where libltdl/configure will be able to find `install-sh' and others. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* libtoolize: simplify runtime by substituting pkgauxdir.Gary V. Vaughan2011-11-172-12/+10
| | | | | | | | * Makefile.am (configure_edit): Substitute pkgauxdir. * libtoolize.m4sh (func_install_pkgaux_subproject) (func_install_pkgaux_parent, extract_trace): Use it. Signed-off-by: Gary V. Vaughan <gary@gnu.org>