From 7f99bfd86c97038b73a1e5d1445ef31c6ec59983 Mon Sep 17 00:00:00 2001 From: "Gary V. Vaughan" Date: Wed, 30 Oct 2013 18:25:44 +1300 Subject: maint: use $SED and $GREP, not sed and grep in all scripts. Choosing between hardcoding a tool's name, or using the shell variable with a path to the user's prefered implementation or configure's idea of the best available is a premature optimisation. * build-aux/ltmain.in, gl/build-aux/bootstrap.in, gl/build-aux/extract-trace, gl/build-aux/funclib.sh, libtoolize.in: Use $SED and $GREP consistently throughout, instead of hardcoding sed and grep. * bootstrap: Regenerate. Signed-off-by: Gary V. Vaughan --- gl/build-aux/bootstrap.in | 8 ++++---- gl/build-aux/extract-trace | 2 +- gl/build-aux/funclib.sh | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) (limited to 'gl') diff --git a/gl/build-aux/bootstrap.in b/gl/build-aux/bootstrap.in index e83835cd..e0237435 100755 --- a/gl/build-aux/bootstrap.in +++ b/gl/build-aux/bootstrap.in @@ -357,7 +357,7 @@ func_reconfigure () func_ensure_changelog else $require_gnulib_cache - if sed -n '/^gl_MODULES(\[/,/^])$/p' $gnulib_cache 2>/dev/null | + if $SED -n '/^gl_MODULES(\[/,/^])$/p' $gnulib_cache 2>/dev/null | func_grep_q gitlog-to-changelog then func_ensure_changelog @@ -774,7 +774,7 @@ func_clean_unused_macros () # We use 'ls|grep' instead of 'ls *.m4' to avoid exceeding # command line length limits in some shells. - for file in `cd "$macro_dir" && ls -1 |grep '\.m4$'`; do + for file in `cd "$macro_dir" && ls -1 |$GREP '\.m4$'`; do # Remove a macro file when aclocal.m4 does not m4_include it... func_grep_q 'm4_include([[]'$macro_dir/$file'])' $aclocal_m4s \ @@ -2261,7 +2261,7 @@ func_gitignore_entries () { $debug_cmd - sed -e '/^#/d' -e '/^$/d' "$@" + $SED -e '/^#/d' -e '/^$/d' "$@" } @@ -2294,7 +2294,7 @@ func_insert_if_absent () linesnew=`{ $bs_echo "$str"; cat "$file"; } \ |func_gitignore_entries |sort -u |wc -l` test "$linesold" -eq "$linesnew" \ - || { sed "1i\\$nl$str$nl" "$file" >"$file"T && mv "$file"T "$file"; } \ + || { $SED "1i\\$nl$str$nl" "$file" >"$file"T && mv "$file"T "$file"; } \ || func_permissions_error "$file" done } diff --git a/gl/build-aux/extract-trace b/gl/build-aux/extract-trace index 5e42ea78..ece24d77 100755 --- a/gl/build-aux/extract-trace +++ b/gl/build-aux/extract-trace @@ -68,7 +68,7 @@ func_autoconf_configure () # If we were passed a genuine file, make sure it calls AC_INIT. test -f "$1" \ - && _G_ac_init=`$SED "$_G_sed_no_comment" "$1" |grep AC_INIT` + && _G_ac_init=`$SED "$_G_sed_no_comment" "$1" |$GREP AC_INIT` # Otherwise it is not a genuine Autoconf input file. test -n "$_G_ac_init" diff --git a/gl/build-aux/funclib.sh b/gl/build-aux/funclib.sh index 7dd99c17..2746827b 100644 --- a/gl/build-aux/funclib.sh +++ b/gl/build-aux/funclib.sh @@ -730,11 +730,11 @@ func_echo_infix_1 () for _G_tc in "$tc_reset" "$tc_bold" "$tc_standout" "$tc_red" "$tc_green" "$tc_blue" "$tc_cyan" do test -n "$_G_tc" && { - _G_esc_tc=`$bs_echo "$_G_tc" | sed "$sed_make_literal_regex"` - _G_indent=`$bs_echo "$_G_indent" | sed "s|$_G_esc_tc||g"` + _G_esc_tc=`$bs_echo "$_G_tc" | $SED "$sed_make_literal_regex"` + _G_indent=`$bs_echo "$_G_indent" | $SED "s|$_G_esc_tc||g"` } done - _G_indent="$progname: "`echo "$_G_indent" | sed 's|.| |g'`" " ## exclude from sc_prohibit_nested_quotes + _G_indent="$progname: "`echo "$_G_indent" | $SED 's|.| |g'`" " ## exclude from sc_prohibit_nested_quotes func_echo_infix_1_IFS=$IFS IFS=$nl @@ -1331,7 +1331,7 @@ func_lt_ver () { $debug_cmd - test "x$1" = x`func_sort_ver "$1" "$2" | sed 1q` + test "x$1" = x`func_sort_ver "$1" "$2" | $SED 1q` } -- cgit v1.2.1