<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libvirt.git/src/locking, branch master</title>
<subtitle>libvirt.org: git/libvirt.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/'/>
<entry>
<title>meson: Use initconfdir</title>
<updated>2023-05-05T13:08:25+00:00</updated>
<author>
<name>Andrea Bolognani</name>
<email>abologna@redhat.com</email>
</author>
<published>2023-04-29T16:23:12+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=32f772e98659eba8b93e940698102464c4b91209'/>
<id>32f772e98659eba8b93e940698102464c4b91209</id>
<content type='text'>
Signed-off-by: Andrea Bolognani &lt;abologna@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Andrea Bolognani &lt;abologna@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>meson: Work around configure_file(copy:true) deprecation</title>
<updated>2023-04-20T13:30:18+00:00</updated>
<author>
<name>Michal Privoznik</name>
<email>mprivozn@redhat.com</email>
</author>
<published>2023-03-23T10:11:42+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=ac7f3667f2dde0dd391048a8417c6d40dae1b99e'/>
<id>ac7f3667f2dde0dd391048a8417c6d40dae1b99e</id>
<content type='text'>
In our meson scripts, we use configure_file(copy:true) to copy
files from srcdir into builddir. However, as of meson-0.64.0,
this is deprecated [1] in favor of using:

  fs = import('fs')
  fs.copyfile(in, out)

Except, the submodule's new method wasn't introduced until
0.64.0. And since we can't bump the minimal meson version we
require, we have to work with both: new and old versions.

Now, the fun part: fs.copyfile() is not a drop in replacement as
it returns different type (a custom_target object). This is
incompatible with places where we store the configure_file()
retval in a variable to process it further.

While we could just replace 'copy:true' with a dummy
'configuration:...' (say 'configuration: configmake_conf') we
can't do that for binary files (like src/fonts/ or src/images/).

Therefore, places where we are not interested in the retval can
be switched to fs.copyfile() and places where we are interested
in the retval will just use a dummy 'configuration:'.

Except, src/network/meson.build. In here we not just copy the
file but also specify alternative install dir and that's not
something that fs.copyfile() can handle. Yet, using 'copy: true'
is viewed wrong [2].

1: https://mesonbuild.com/Release-notes-for-0-64-0.html#fscopyfile-to-replace-configure_filecopy-true
2: https://github.com/mesonbuild/meson/pull/10042

Signed-off-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In our meson scripts, we use configure_file(copy:true) to copy
files from srcdir into builddir. However, as of meson-0.64.0,
this is deprecated [1] in favor of using:

  fs = import('fs')
  fs.copyfile(in, out)

Except, the submodule's new method wasn't introduced until
0.64.0. And since we can't bump the minimal meson version we
require, we have to work with both: new and old versions.

Now, the fun part: fs.copyfile() is not a drop in replacement as
it returns different type (a custom_target object). This is
incompatible with places where we store the configure_file()
retval in a variable to process it further.

While we could just replace 'copy:true' with a dummy
'configuration:...' (say 'configuration: configmake_conf') we
can't do that for binary files (like src/fonts/ or src/images/).

Therefore, places where we are not interested in the retval can
be switched to fs.copyfile() and places where we are interested
in the retval will just use a dummy 'configuration:'.

Except, src/network/meson.build. In here we not just copy the
file but also specify alternative install dir and that's not
something that fs.copyfile() can handle. Yet, using 'copy: true'
is viewed wrong [2].

1: https://mesonbuild.com/Release-notes-for-0-64-0.html#fscopyfile-to-replace-configure_filecopy-true
2: https://github.com/mesonbuild/meson/pull/10042

Signed-off-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>locking: Update format strings in translated messages</title>
<updated>2023-04-01T09:40:33+00:00</updated>
<author>
<name>Jiri Denemark</name>
<email>jdenemar@redhat.com</email>
</author>
<published>2023-03-09T11:15:50+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=3d61757c3bec5cf5c0e6a5a5d4200dda3eec4490'/>
<id>3d61757c3bec5cf5c0e6a5a5d4200dda3eec4490</id>
<content type='text'>
Signed-off-by: Jiri Denemark &lt;jdenemar@redhat.com&gt;
Reviewed-by: Daniel P. Berrangé &lt;berrange@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jiri Denemark &lt;jdenemar@redhat.com&gt;
Reviewed-by: Daniel P. Berrangé &lt;berrange@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>util: virPidFileAcquirePath: remove waitForLock argument</title>
<updated>2023-03-08T11:16:56+00:00</updated>
<author>
<name>Ján Tomko</name>
<email>jtomko@redhat.com</email>
</author>
<published>2023-03-07T13:49:33+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=d3d16f829bf739e3099e8d18c1c9a45b32229eff'/>
<id>d3d16f829bf739e3099e8d18c1c9a45b32229eff</id>
<content type='text'>
None of the callers need it anymore.

Signed-off-by: Ján Tomko &lt;jtomko@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
None of the callers need it anymore.

Signed-off-by: Ján Tomko &lt;jtomko@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>locking: use g_autofree and remove unnecessary label</title>
<updated>2023-01-09T03:38:52+00:00</updated>
<author>
<name>Jiang Jiacheng</name>
<email>jiangjiacheng@huawei.com</email>
</author>
<published>2023-01-06T09:18:33+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=075cfd842e04876f64b8750530cd7e653c34914a'/>
<id>075cfd842e04876f64b8750530cd7e653c34914a</id>
<content type='text'>
Signed-off-by: Jiang Jiacheng &lt;jiangjiacheng@huawei.com&gt;
Reviewed-by: Jonathon Jongsma &lt;jjongsma@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
Signed-off-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Jiang Jiacheng &lt;jiangjiacheng@huawei.com&gt;
Reviewed-by: Jonathon Jongsma &lt;jjongsma@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
Signed-off-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>lib: Use the same style in the 'struct option'</title>
<updated>2022-11-22T09:15:11+00:00</updated>
<author>
<name>Jiang Jiacheng</name>
<email>jiangjiacheng@huawei.com</email>
</author>
<published>2022-11-22T01:50:01+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=4b90adf65a80c33f3359ba9af01759a2551b51cc'/>
<id>4b90adf65a80c33f3359ba9af01759a2551b51cc</id>
<content type='text'>
Use same style in the 'struct option' as:
    struct option opt[] = {
        { a, b },
        { a, b },
        ...
        { a, b },
    };

Signed-off-by: Jiang Jiacheng &lt;jiangjiacheng@huawei.com&gt;
Reviewed-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use same style in the 'struct option' as:
    struct option opt[] = {
        { a, b },
        { a, b },
        ...
        { a, b },
    };

Signed-off-by: Jiang Jiacheng &lt;jiangjiacheng@huawei.com&gt;
Reviewed-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>virNetDaemonAutoShutdown: Allow live update of shutdown timeout</title>
<updated>2022-07-07T12:35:30+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2022-06-13T12:25:06+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=c53e0c95353757fbeffd0a401c6659f1eb2195cd'/>
<id>c53e0c95353757fbeffd0a401c6659f1eb2195cd</id>
<content type='text'>
Modify the code so that calling 'virNetDaemonAutoShutdown' will update
the auto shutdown timeout also for running daemons.

This involves changing the logic when to do the update of the timer so
that it can be called from both when the daemon is not yet runnign and
when doing a live update.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Modify the code so that calling 'virNetDaemonAutoShutdown' will update
the auto shutdown timeout also for running daemons.

This involves changing the logic when to do the update of the timer so
that it can be called from both when the daemon is not yet runnign and
when doing a live update.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>locking: Remove unused includes</title>
<updated>2022-06-16T04:43:56+00:00</updated>
<author>
<name>Peng Liang</name>
<email>tcx4c70@gmail.com</email>
</author>
<published>2022-06-08T12:12:58+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=58391e6dea66501094165d01ac9f8c04a7d07fe4'/>
<id>58391e6dea66501094165d01ac9f8c04a7d07fe4</id>
<content type='text'>
Signed-off-by: Peng Liang &lt;tcx4c70@gmail.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Peng Liang &lt;tcx4c70@gmail.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>virStorageSourceGetActualType: Change type of retval</title>
<updated>2022-06-01T12:54:59+00:00</updated>
<author>
<name>Michal Privoznik</name>
<email>mprivozn@redhat.com</email>
</author>
<published>2022-01-23T11:10:35+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=215b2466cd45bd00d4d71db40364384c0bf9313d'/>
<id>215b2466cd45bd00d4d71db40364384c0bf9313d</id>
<content type='text'>
The virStorageSourceGetActualType() function returns either
virStorageSource-&gt;type (which is of type virStorageType), or
virStorageSourcePoolDef-&gt;type, which really stores a value of the
same enum. Thus, the latter struct can be changed so that the
virStorageSourceGetActualType() function can return correct type
instead of generic int.

Signed-off-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Reviewed-by: Boris Fiuczynski &lt;fiuczy@linux.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The virStorageSourceGetActualType() function returns either
virStorageSource-&gt;type (which is of type virStorageType), or
virStorageSourcePoolDef-&gt;type, which really stores a value of the
same enum. Thus, the latter struct can be changed so that the
virStorageSourceGetActualType() function can return correct type
instead of generic int.

Signed-off-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Reviewed-by: Boris Fiuczynski &lt;fiuczy@linux.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>util: drop support for obsolete systemd in RHEL-7</title>
<updated>2022-02-17T12:35:42+00:00</updated>
<author>
<name>Daniel P. Berrangé</name>
<email>berrange@redhat.com</email>
</author>
<published>2022-02-16T14:57:05+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=b56a833243ca7324dcc13e731b20114a060bba61'/>
<id>b56a833243ca7324dcc13e731b20114a060bba61</id>
<content type='text'>
The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
variable with socket activation. Since we stopped targetting RHEL-7 we
can drop some considerable amount of compatibility code.

Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
Signed-off-by: Daniel P. Berrangé &lt;berrange@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
variable with socket activation. Since we stopped targetting RHEL-7 we
can drop some considerable amount of compatibility code.

Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
Signed-off-by: Daniel P. Berrangé &lt;berrange@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
