<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libvirt.git/tests/qemuxml2argvdata/numatune-memnode-no-memory.args, branch master</title>
<subtitle>libvirt.org: git/libvirt.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/'/>
<entry>
<title>tests: Drop more QEMU driver config overrides</title>
<updated>2023-03-06T13:44:13+00:00</updated>
<author>
<name>Andrea Bolognani</name>
<email>abologna@redhat.com</email>
</author>
<published>2023-03-02T18:05:53+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=0b464cd84ff3f83ca8a63bf4c28a0517a9a98288'/>
<id>0b464cd84ff3f83ca8a63bf4c28a0517a9a98288</id>
<content type='text'>
These are allegedly necessary to keep the output consistent,
but now that we're using a privileged config for the driver we
get the desired behavior out of the box, and as a bonus the
paths match what you would actually see on a regular host.

Signed-off-by: Andrea Bolognani &lt;abologna@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These are allegedly necessary to keep the output consistent,
but now that we're using a privileged config for the driver we
get the desired behavior out of the box, and as a bonus the
paths match what you would actually see on a regular host.

Signed-off-by: Andrea Bolognani &lt;abologna@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: command: Always assume QEMU_CAPS_AUDIODEV</title>
<updated>2022-08-11T12:38:31+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2022-06-22T13:36:23+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=31ee59d4e10bacce6d69c5e338b8c6dd018a4e4f'/>
<id>31ee59d4e10bacce6d69c5e338b8c6dd018a4e4f</id>
<content type='text'>
Generate only new version of the '-audiodev' commandline. The leftover
old code and validation will be removed in subsequent patches.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Generate only new version of the '-audiodev' commandline. The leftover
old code and validation will be removed in subsequent patches.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: command: Always assume QEMU_CAPS_OVERCOMMIT</title>
<updated>2022-04-04T10:26:59+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2022-02-10T11:57:26+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=edfd78d7f656927b2556df68b936b5ecf8629832'/>
<id>edfd78d7f656927b2556df68b936b5ecf8629832</id>
<content type='text'>
Starting with qemu-3.1 we always have the '-overcommit' argument and use
it instead of '-realtime'. Remove the capability check and fix all
fake-caps tests.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Starting with qemu-3.1 we always have the '-overcommit' argument and use
it instead of '-realtime'. Remove the capability check and fix all
fake-caps tests.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: Always assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE</title>
<updated>2022-04-04T10:26:59+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2022-02-03T12:31:28+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=47b6829edc5c89bf3b90ea9d7d85ec428b8039ee'/>
<id>47b6829edc5c89bf3b90ea9d7d85ec428b8039ee</id>
<content type='text'>
All qemu versions now support FD passing either directly or via FDset.
Assume that we always have this capability so that we can simplify
chardev handling in many cases.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
All qemu versions now support FD passing either directly or via FDset.
Assume that we always have this capability so that we can simplify
chardev handling in many cases.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: Switch to -accel</title>
<updated>2021-11-22T12:06:54+00:00</updated>
<author>
<name>Michal Privoznik</name>
<email>mprivozn@redhat.com</email>
</author>
<published>2021-11-05T08:38:10+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=d20ebdda28fe254727989102bd5522aafe42cc25'/>
<id>d20ebdda28fe254727989102bd5522aafe42cc25</id>
<content type='text'>
We currently use -machine accel=XXX which is just a syntax sugar
for -accel XXX. The former doesn't allow specifying arguments for
accelerator, because all arguments passed to -machine are
treated as arguments of machine itself.

The -accel argument was introduced in QEMU commit
v2.9.0-rc0~70^2~19 and since our minimum required version is
newer (2.11.0) we can safely assume its existence and use it
without any capability.

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/233
Signed-off-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Tested-by: Kashyap Chamarthy &lt;kchamart@redhat.com&gt;
Reviewed-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We currently use -machine accel=XXX which is just a syntax sugar
for -accel XXX. The former doesn't allow specifying arguments for
accelerator, because all arguments passed to -machine are
treated as arguments of machine itself.

The -accel argument was introduced in QEMU commit
v2.9.0-rc0~70^2~19 and since our minimum required version is
newer (2.11.0) we can safely assume its existence and use it
without any capability.

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/233
Signed-off-by: Michal Privoznik &lt;mprivozn@redhat.com&gt;
Tested-by: Kashyap Chamarthy &lt;kchamart@redhat.com&gt;
Reviewed-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: Always assume presence of QEMU_CAPS_OBJECT_SECRET</title>
<updated>2021-09-22T12:53:55+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2021-09-21T15:50:00+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=0ae3e1313f159163a9a966d86f48e922601971db'/>
<id>0ae3e1313f159163a9a966d86f48e922601971db</id>
<content type='text'>
The secret object is supported since qemu-2.6 and can't be compiled out.
Assume the presence to simplify the code.

This enables the use of the secret key for most tests not using real
caps.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The secret object is supported since qemu-2.6 and can't be compiled out.
Assume the presence to simplify the code.

This enables the use of the secret key for most tests not using real
caps.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: command: Always assume 'QEMU_CAPS_BOOT_STRICT'</title>
<updated>2021-09-21T10:26:06+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2021-09-20T14:22:59+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=e2aa0c3b5a83b291ddbe00bc00ffec65c61ab177'/>
<id>e2aa0c3b5a83b291ddbe00bc00ffec65c61ab177</id>
<content type='text'>
Added by c8a6ae8bb9 in qemu-v1.5.0 and can't be compiled out. Assume
that it's present and fix all fake-caps tests.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Added by c8a6ae8bb9 in qemu-v1.5.0 and can't be compiled out. Assume
that it's present and fix all fake-caps tests.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: command: Always assume support for '-msg timestamp=on'</title>
<updated>2021-08-18T08:00:22+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2021-08-10T15:07:10+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=c7a85b5b7792212c9e8f5f824a139e50edf68f3c'/>
<id>c7a85b5b7792212c9e8f5f824a139e50edf68f3c</id>
<content type='text'>
All supported QEMU versions have this option so there's no need for us
to base it on the capability.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
All supported QEMU versions have this option so there's no need for us
to base it on the capability.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: command: Always assume support for '-name guest=' and '-name debug-threads=on'</title>
<updated>2021-08-18T07:59:31+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2021-08-10T14:39:38+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=d5a61459003e3d23c38868364941e98a65fd29dd'/>
<id>d5a61459003e3d23c38868364941e98a65fd29dd</id>
<content type='text'>
All QEMU versions we support have these and it's very unlikely that they
will be removed. Remove the capability checks.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
All QEMU versions we support have these and it's very unlikely that they
will be removed. Remove the capability checks.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Martin Kletzander &lt;mkletzan@redhat.com&gt;
Reviewed-by: Ján Tomko &lt;jtomko@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qemu: capabilities: Move setting QEMU_CAPS_DEVICE_VIDEO_PRIMARY to virQEMUCapsInitQMPBasicArch</title>
<updated>2021-05-03T10:14:44+00:00</updated>
<author>
<name>Peter Krempa</name>
<email>pkrempa@redhat.com</email>
</author>
<published>2021-03-30T15:48:46+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libvirt.git/commit/?id=1924ef661ba00691d93d30dff9c8a54e776a2f9e'/>
<id>1924ef661ba00691d93d30dff9c8a54e776a2f9e</id>
<content type='text'>
Until we clean up and remove all capabilities which no longer make sense
to have separately, we should use virQEMUCapsInitQMPBasicArch to set the
defaults as it's used by qemuxml2argvtest when testing with fake
capabilities.

This allows us to prevent testing dead code paths with the fake
capability tests.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Pavel Hrdina &lt;phrdina@redhat.com&gt;
Reviewed-by: Neal Gompa &lt;ngompa13@gmail.com&gt;
Reviewed-by: Pavel Hrdina &lt;phrdina@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Until we clean up and remove all capabilities which no longer make sense
to have separately, we should use virQEMUCapsInitQMPBasicArch to set the
defaults as it's used by qemuxml2argvtest when testing with fake
capabilities.

This allows us to prevent testing dead code paths with the fake
capability tests.

Signed-off-by: Peter Krempa &lt;pkrempa@redhat.com&gt;
Reviewed-by: Pavel Hrdina &lt;phrdina@redhat.com&gt;
Reviewed-by: Neal Gompa &lt;ngompa13@gmail.com&gt;
Reviewed-by: Pavel Hrdina &lt;phrdina@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
