summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJán Tomko <jtomko@redhat.com>2013-04-12 17:30:56 +0200
committerJán Tomko <jtomko@redhat.com>2013-05-16 16:01:16 +0200
commit7d5e3f026603d7e6d78254e972332fdd6b234863 (patch)
tree816b3d7527f2504ddb8e0eef3a6d3991deb516b0
parent8e2d8d19bd3a6ab1ebc75f1ab03674c1b7cd22cd (diff)
downloadlibvirt-7d5e3f026603d7e6d78254e972332fdd6b234863.tar.gz
daemon: fix leak after listing all volumes
CVE-2013-1962 remoteDispatchStoragePoolListAllVolumes wasn't freeing the pool. The pool also held a reference to the connection, preventing it from getting freed and closing the netcf interface driver, which held two sockets open. (cherry picked from commit ca697e90d5bd6a6dfb94bfb6d4438bdf9a44b739)
-rw-r--r--daemon/remote.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/daemon/remote.c b/daemon/remote.c
index c92223eacd..e879941fc0 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -4233,6 +4233,8 @@ cleanup:
virStorageVolFree(vols[i]);
VIR_FREE(vols);
}
+ if (pool)
+ virStoragePoolFree(pool);
return rv;
}