summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Kletzander <mkletzan@redhat.com>2014-04-02 08:57:59 +0200
committerMartin Kletzander <mkletzan@redhat.com>2014-04-09 18:29:04 +0200
commitd9af0809b055581f837038dd80e6c69f442dfea1 (patch)
tree63b0a50fcf87b6f8a8a58c0a5ec0abec5ae43060
parent49e60cca08fd957aa9c4b06e101b34788eb3721e (diff)
downloadlibvirt-d9af0809b055581f837038dd80e6c69f442dfea1.tar.gz
qemu: remove unneeded forward declaration
by moving qemuAgentCommand() after qemuAgentCheckError(). Signed-off-by: Martin Kletzander <mkletzan@redhat.com> (cherry picked from commit e9d09fe19680fcb1810774023aa5c2ef007b10c6) Conflicts: src/qemu/qemu_agent.c -- label indentation (5922d05a) comment removal (56874f01)
-rw-r--r--src/qemu/qemu_agent.c114
1 files changed, 55 insertions, 59 deletions
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index db205c4e9e..f6009cb8db 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@ -115,8 +115,6 @@ struct _qemuAgent {
qemuAgentEvent await_event;
};
-static int qemuAgentCheckError(virJSONValuePtr cmd, virJSONValuePtr reply);
-
static virClassPtr qemuAgentClass;
static void qemuAgentDispose(void *obj);
@@ -965,63 +963,6 @@ cleanup:
return ret;
}
-static int
-qemuAgentCommand(qemuAgentPtr mon,
- virJSONValuePtr cmd,
- virJSONValuePtr *reply,
- int seconds)
-{
- int ret = -1;
- qemuAgentMessage msg;
- char *cmdstr = NULL;
- int await_event = mon->await_event;
-
- *reply = NULL;
-
- if (qemuAgentGuestSync(mon) < 0) {
- /* helper reported the error */
- return -1;
- }
-
- memset(&msg, 0, sizeof(msg));
-
- if (!(cmdstr = virJSONValueToString(cmd, false)))
- goto cleanup;
- if (virAsprintf(&msg.txBuffer, "%s" LINE_ENDING, cmdstr) < 0)
- goto cleanup;
- msg.txLength = strlen(msg.txBuffer);
-
- VIR_DEBUG("Send command '%s' for write, seconds = %d", cmdstr, seconds);
-
- ret = qemuAgentSend(mon, &msg, seconds);
-
- VIR_DEBUG("Receive command reply ret=%d rxObject=%p",
- ret, msg.rxObject);
-
- if (ret == 0) {
- /* If we haven't obtained any reply but we wait for an
- * event, then don't report this as error */
- if (!msg.rxObject) {
- if (await_event) {
- VIR_DEBUG("Woken up by event %d", await_event);
- } else {
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
- _("Missing monitor reply object"));
- ret = -1;
- }
- } else {
- *reply = msg.rxObject;
- ret = qemuAgentCheckError(cmd, *reply);
- }
- }
-
-cleanup:
- VIR_FREE(cmdstr);
- VIR_FREE(msg.txBuffer);
-
- return ret;
-}
-
static const char *
qemuAgentStringifyErrorClass(const char *klass)
{
@@ -1133,6 +1074,61 @@ qemuAgentCheckError(virJSONValuePtr cmd,
return 0;
}
+static int
+qemuAgentCommand(qemuAgentPtr mon,
+ virJSONValuePtr cmd,
+ virJSONValuePtr *reply,
+ int seconds)
+{
+ int ret = -1;
+ qemuAgentMessage msg;
+ char *cmdstr = NULL;
+ int await_event = mon->await_event;
+
+ *reply = NULL;
+
+ if (qemuAgentGuestSync(mon) < 0)
+ return -1;
+
+ memset(&msg, 0, sizeof(msg));
+
+ if (!(cmdstr = virJSONValueToString(cmd, false)))
+ goto cleanup;
+ if (virAsprintf(&msg.txBuffer, "%s" LINE_ENDING, cmdstr) < 0)
+ goto cleanup;
+ msg.txLength = strlen(msg.txBuffer);
+
+ VIR_DEBUG("Send command '%s' for write, seconds = %d", cmdstr, seconds);
+
+ ret = qemuAgentSend(mon, &msg, seconds);
+
+ VIR_DEBUG("Receive command reply ret=%d rxObject=%p",
+ ret, msg.rxObject);
+
+ if (ret == 0) {
+ /* If we haven't obtained any reply but we wait for an
+ * event, then don't report this as error */
+ if (!msg.rxObject) {
+ if (await_event) {
+ VIR_DEBUG("Woken up by event %d", await_event);
+ } else {
+ virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+ _("Missing monitor reply object"));
+ ret = -1;
+ }
+ } else {
+ *reply = msg.rxObject;
+ ret = qemuAgentCheckError(cmd, *reply);
+ }
+ }
+
+ cleanup:
+ VIR_FREE(cmdstr);
+ VIR_FREE(msg.txBuffer);
+
+ return ret;
+}
+
static virJSONValuePtr ATTRIBUTE_SENTINEL
qemuAgentMakeCommand(const char *cmdname,
...)