diff options
author | Michal Privoznik <mprivozn@redhat.com> | 2015-10-12 16:37:15 +0200 |
---|---|---|
committer | Michal Privoznik <mprivozn@redhat.com> | 2015-10-12 16:37:15 +0200 |
commit | 179d92c8481b2229edbfb233614328e08ab79dfc (patch) | |
tree | b656b4bbd0cf9fd62e55c80eb2a621cbf54e67ef | |
parent | 5275c0f4a1267c630b5c3b77fac8cbe4fcaa3adb (diff) | |
download | libvirt-179d92c8481b2229edbfb233614328e08ab79dfc.tar.gz |
libvirt-domain: Drop virDomainMigrateCheckNotLocal attribute
Our apibuild.py script does not cope with ATTRIBUTE_NONNULL:
Parse Error: parsing function type, ')' expected
Got token ('name', 'char')
Last token: ('name', 'char')
Token queue: [('op', '*'), ('name', 'dconnuri'), ('sep', ')')]
Line 3297 end:
Makefile:2441: recipe for target '../../docs/apibuild.py.stamp' failed
Let's drop it. Moreover, up until e17ae3ccc2dbc1400 where it was
introduced we did not really care about NULL-ity of dconnuri. And
moreover the ATTRIBUTE_NONNULL merely checks for static calls
over NULL, it won't catch the dynamic ones, where a NULL is
passed by a variable at runtime.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
-rw-r--r-- | src/libvirt-domain.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index e6c8604e47..6e1aacdd95 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3293,7 +3293,7 @@ virDomainMigrateVersion3Params(virDomainPtr domain, } -static int ATTRIBUTE_NONNULL(1) +static int virDomainMigrateCheckNotLocal(const char *dconnuri) { virURIPtr tempuri = NULL; |