diff options
author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:16:14 +0200 |
---|---|---|
committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 10:21:36 +0200 |
commit | 5632ca00ef8b75ce600ebb7255d392339c07b967 (patch) | |
tree | cf008c284bf1dabc5fc1624299e4590e6134b1a7 | |
parent | 70e83151456d386580708ade404ada41afac41dd (diff) | |
download | libvirt-5632ca00ef8b75ce600ebb7255d392339c07b967.tar.gz |
api: disallow virConnectGetDomainCapabilities on read-only connectionsv1.3.5-maint
This API can be used to execute arbitrary emulators.
Forbid it on read-only connections.
Fixes: CVE-2019-10167
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 8afa68bac0cf99d1f8aaa6566685c43c22622f26)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
-rw-r--r-- | src/libvirt-domain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index a021434e43..f4228cedb4 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11309,6 +11309,7 @@ virConnectGetDomainCapabilities(virConnectPtr conn, virResetLastError(); virCheckConnectReturn(conn, NULL); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectGetDomainCapabilities) { char *ret; |