tests: Add virtTestCompareToFile

Replaces a common pattern used in many test files

1 files changed, 1 insertions, 8 deletions

diff --git a/tests/sexpr2xmltest.c b/tests/sexpr2xmltest.c
index 7247414c19..99999f1e6a 100644
--- a/tests/sexpr2xmltest.c
+++ b/tests/sexpr2xmltest.c
@@ -21,7 +21,6 @@ static virCapsPtr caps;
 static int
 testCompareFiles(const char *xml, const char *sexpr, int xendConfigVersion)
 {
-  char *xmlData = NULL;
   char *sexprData = NULL;
   char *gotxml = NULL;
   int id;
@@ -36,9 +35,6 @@ testCompareFiles(const char *xml, const char *sexpr, int xendConfigVersion)
   conn = virGetConnect();
   if (!conn) goto fail;
 
-  if (virtTestLoadFile(xml, &xmlData) < 0)
-      goto fail;
-
   if (virtTestLoadFile(sexpr, &sexprData) < 0)
       goto fail;
 
@@ -68,15 +64,12 @@ testCompareFiles(const char *xml, const char *sexpr, int xendConfigVersion)
   if (!(gotxml = virDomainDefFormat(def, 0)))
       goto fail;
 
-  if (STRNEQ(xmlData, gotxml)) {
-      virtTestDifference(stderr, xmlData, gotxml);
+  if (virtTestCompareToFile(gotxml, xml) < 0)
       goto fail;
-  }
 
   ret = 0;
 
  fail:
-  VIR_FREE(xmlData);
   VIR_FREE(sexprData);
   VIR_FREE(gotxml);
   virDomainDefFree(def);