From 80e50315b45d1dbeb44025a697caf212700d3931 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 26 May 2022 14:58:19 +0200 Subject: docs: patches: Add a note about reviews and contacting developers Add a note outling best practices around review and responding to it. Signed-off-by: Peter Krempa Reviewed-by: Erik Skultety --- docs/submitting-patches.rst | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'docs') diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index 7bc22323ee..4cae82c771 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -89,3 +89,24 @@ Moreover, such patch needs to be prefixed correctly with ``--subject-prefix=PATCHv2`` appended to ``git send-email`` (substitute ``v2`` with the correct version if needed though). + +Review process +-------------- + +Reviewing patches may take a lot of effort with review bandwidth being limited +in open source projects. Here are a few rules to follow to streamline the +process: + + - **don't** contact individual maintainers/developers directly with your + patches; reviewers are subscribed to the mailing list + - **do** be patient; reviewers may be busy + - **do** respond to reviewer's questions + - **don't** ignore a suggestion from a reviewer; if you disagree discuss it on + the list before sending a new version + - **do** remind us of your patches on the list if they haven't gotten any + attention for a prolonged period (>1 week) by replying to your patches with a + "ping" + - **do** test your patches before sending + +Don't feel obliged to review whole patch series if you see any major problems +in any of the comprising patches - just point them out on the list. -- cgit v1.2.1