diff options
| author | Vincent Rabaud <vrabaud@google.com> | 2018-04-03 15:17:21 +0200 |
|---|---|---|
| committer | James Zern <jzern@google.com> | 2018-04-03 18:38:00 -0700 |
| commit | 3f157dd5e7693fbd7d0163213abc07e5f2f1e612 (patch) | |
| tree | fb3dfd244f70cace533acdb2fcd6a7f2b5eacbda | |
| parent | cd758a17454872ae73996dcfa3bcfb235f067895 (diff) | |
| download | libwebp-3f157dd5e7693fbd7d0163213abc07e5f2f1e612.tar.gz | |
Remove some very hard TODOs.
Change-Id: I3d1b0072e0ac9125840fbbd76e91d151c82489ec
(cherry picked from commit 4033e1d70d8f25904b3a422bf60d7a8973bf688f)
| -rw-r--r-- | src/enc/histogram_enc.c | 2 | ||||
| -rw-r--r-- | src/enc/vp8l_enc.c | 5 |
2 files changed, 2 insertions, 5 deletions
diff --git a/src/enc/histogram_enc.c b/src/enc/histogram_enc.c index aa840783..9fdbc627 100644 --- a/src/enc/histogram_enc.c +++ b/src/enc/histogram_enc.c @@ -1026,7 +1026,7 @@ int VP8LGetHistoImageSymbols(int xsize, int ysize, } } - // TODO(vikasa): Optimize HistogramRemap for low-effort compression mode also. + // TODO(vrabaud): Optimize HistogramRemap for low-effort compression mode. // Find the optimal map from original histograms to the final ones. HistogramRemap(orig_histo, image_histo, histogram_symbols); diff --git a/src/enc/vp8l_enc.c b/src/enc/vp8l_enc.c index 2b3f3486..a89184eb 100644 --- a/src/enc/vp8l_enc.c +++ b/src/enc/vp8l_enc.c @@ -382,8 +382,7 @@ static int EncoderAnalyze(VP8LEncoder* const enc, AnalyzeAndCreatePalette(pic, low_effort, enc->palette_, &enc->palette_size_); - // TODO(jyrki): replace the decision to be based on an actual estimate - // of entropy, or even spatial variance of entropy. + // Empirical bit sizes. enc->histo_bits_ = GetHistoBits(method, use_palette, pic->width, pic->height); enc->transform_bits_ = GetTransformBits(method, enc->histo_bits_); @@ -754,7 +753,6 @@ static WebPEncodingError StoreImageToBitMask( // Don't write the distance with the extra bits code since // the distance can be up to 18 bits of extra bits, and the prefix // 15 bits, totaling to 33, and our PutBits only supports up to 32 bits. - // TODO(jyrki): optimize this further. VP8LPrefixEncode(distance, &code, &n_bits, &bits); WriteHuffmanCode(bw, codes + 4, code); VP8LPutBits(bw, bits, n_bits); @@ -1876,7 +1874,6 @@ int VP8LEncodeImage(const WebPConfig* const config, err = VP8LEncodeStream(config, picture, &bw, 1 /*use_cache*/); if (err != VP8_ENC_OK) goto Error; - // TODO(skal): have a fine-grained progress report in VP8LEncodeStream(). if (!WebPReportProgress(picture, 90, &percent)) goto UserAbort; // Finish the RIFF chunk. |