small memory leak

2 files changed, 8 insertions, 2 deletions

diff --git a/ChangeLog b/ChangeLog
index 014f2ce..d11a6bf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2005-03-11 svu
+	
+	* libxklavier/xklavier_xkb.c: fixed memory leak, precachedXkb.
+	Thanks to kmaraas
+
 2005-02-25 svu
 	
 	* NEWS: update for 2.0
diff --git a/libxklavier/xklavier_xkb.c b/libxklavier/xklavier_xkb.c
index 760ba48..fdb9ddc 100644
--- a/libxklavier/xklavier_xkb.c
+++ b/libxklavier/xklavier_xkb.c
@@ -173,9 +173,10 @@ Bool _XklXkbIfCachedInfoEqualsActual( )
       }
     }
     /** 
-     * in case of success, let's reuse - not free! 
+     * in case of failure, reuse in _XklXkbLoadAllInfo
+     * in case of success - free it
      */
-    if( !rv )
+    if( rv )
     {
       XkbFreeKeyboard( precachedXkb, XkbAllComponentsMask, True );
       precachedXkb = NULL;