summaryrefslogtreecommitdiff
path: root/src/mod_openssl.c
Commit message (Collapse)AuthorAgeFilesLines
* [TLS] $SERVER["socket"] inherit global ssl.engineGlenn Strauss2023-05-031-1/+26
| | | | | | | | | | | | | | | | | | $SERVER["socket"] inherits ssl.engine = "enable" from global scope fixes issue of TLS-enabled socket, but missing config, if ssl.engine = "enable" in global scope and $SERVER["socket"] does not contain ssl.engine = "enable" e.g. default TLS-enabled, and explicitly disabled on specific sockets server.port = 443 ssl.engine = "enable" ssl.pemfile = ... ssl.privkey = ... $SERVER["socket"] == ":80" { ssl.engine = "disable" } $SERVER["socket"] == "[::]:80" { ssl.engine = "disable" } $SERVER["socket"] == " :443" { } $SERVER["socket"] == "[::]:443" { }
* [build] _WIN32 __declspec(dllexport) *_plugin_initGlenn Strauss2023-05-031-0/+1
| | | | _WIN32 __declspec(dllexport) on mod_*_plugin_init()
* [multiple] _WIN32 misc compatGlenn Strauss2023-05-031-0/+6
| | | | | | | Use #define __USE_MINGW_ANSI_STDIO 1 to use __mingw_printf() to support %lld %zu and other C11 stdio support msvcrt.dll only supports C89, and has not been linked into dlls by MS since VC++ 6
* [mod_openssl] SSL_CTX_set_options() takes uint64_tGlenn Strauss2023-04-041-1/+8
| | | | SSL_CTX_set_options() takes uint64_t for options in openssl 3.0+
* [multiple] codespell: correct spelling in commentsGlenn Strauss2023-01-071-1/+1
|
* [TLS] fix spurious warning trace (fixes #3182)Glenn Strauss2023-01-051-2/+2
| | | | | | | | (thx flynn) x-ref: "Test config reports invalid ssl.pemfile in $HTTP["host"] condition" https://redmine.lighttpd.net/issues/3182
* [mod_openssl] CLOSE_NOTIFY handling with KTLSGlenn Strauss2022-12-111-18/+16
| | | | | adjust CLOSE_NOTIFY handling to avoid excess error trace after SSL_shutdown()
* [multiple] employ ck_calloc, ck_malloc shared codeGlenn Strauss2022-12-101-13/+6
| | | | | employ ck_calloc(), ck_malloc() shared code to slightly reduce code size (centralize the ck_assert() to check that memory allocation succeeded)
* [multiple] mark mod_*_plugin_init() funcs coldGlenn Strauss2022-12-071-0/+1
|
* [TLS] simplify TLS config; remove deprecated optsGlenn Strauss2022-11-301-120/+32
| | | | | | | | | | | | | | | | | simplify TLS config; remove deprecated options These scheduled lighttpd behavior changes have been announced over the past year. lighttpd aims to provide reasonably secure TLS configuration defaults, and to periodically review and update TLS configuration defaults. Doing so reduces the need for distros, packagers, and end-users to specify their own TLS config customizations, which may then be neglected or cargo-culted far into the future, instead of being periodically updated to use stronger defaults. x-ref: https://wiki.lighttpd.net/Docs_SSL
* [TLS] upgrade default cipher list to stronger setGlenn Strauss2022-11-301-1/+6
| | | | | | | | | | | | | | | | | | | | | upgrade default cipher list to stronger set, changing default from "HIGH" to "EECDH+AESGCM:AES256+EECDH:CHACHA20:!SHA1:!SHA256:!SHA384" openssl ciphers 'EECDH+AESGCM:AES256+EECDH:CHACHA20:!SHA1:!SHA256:!SHA384' expands to "TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:TLS_AES_128_CCM_SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-CCM8:ECDHE-ECDSA-AES256-CCM:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-CHACHA20-POLY1305:RSA-PSK-CHACHA20-POLY1305:DHE-PSK-CHACHA20-POLY1305:ECDHE-PSK-CHACHA20-POLY1305:PSK-CHACHA20-POLY1305" Most of these ciphers are widely supported and have been for many years. These scheduled lighttpd behavior changes have been announced over the past year. Providing a strong default cipher list reduces the need for distros, packagers, and end-users to specify their own cipher lists, which may then be neglected or cargo-culted far into the future, instead of being periodically updated to use stronger defaults. x-ref: https://wiki.lighttpd.net/Docs_SSL
* [TLS] handle '+' on ssl-conf-cmd "Options"Glenn Strauss2022-11-301-0/+2
|
* [mod_openssl] use SSL_sendfile() if KTLS availableGlenn Strauss2022-11-301-0/+66
| | | | | | | | For HTTP/1.x responses streaming files from disk, SSL_sendfile() (when KTLS is available) might reduce CPU usage and copying between userspace and kernel. disable with: ssl.openssl.ssl-conf-cmd += ( "Options" => "-KTLS" )
* [mod_openssl] mod_openssl_write_err() shared codeGlenn Strauss2022-11-301-51/+60
|
* [mod_openssl] libressl 3.6.0 ASN1_TIME_cmp_time_tGlenn Strauss2022-11-231-2/+5
| | | | libressl 3.6.0 added ASN1_TIME_cmp_time_t()
* [TLS] try DER format if reading PEM format failsGlenn Strauss2022-10-261-3/+8
| | | | try DER format if reading PEM format fails for ssl.pemfile, ssl.privkey
* [TLS] ssl.openssl.ssl-conf-cmd "DHParameters"Glenn Strauss2022-10-011-75/+89
| | | | | | | | | support "DHParameters" in ssl.openssl.ssl-conf-cmd (replacement for ssl.dh-file) isolate code setting DHParameters into its own subroutine (code reuse) Note: TLS library defaults should be preferred over specifying DH params
* [mod_openssl] compile compat w/ openssl < 1.1.0Glenn Strauss2022-06-161-1/+9
| | | | | | (thx gmd20) github: closes #112
* [TLS] inherit ssl.engine from global scopeGlenn Strauss2022-06-041-6/+0
| | | | | | | | | | | | | | | | | | | | | | Since lighttpd 1.4.56, an oversight in config processing missed setting explicitly p->conf.ssl_enabled = 0 in network.c when initializing conditions. When ssl.engine = "enable" in lighttpd.conf global scope, the missing reset in network.c required non-TLS ports (e.g. $SERVER["socket"] == ":80") to contain ssl.engine = "disable" in order for requests to those ports to be served rather than erroring. (This error was discovered during collaboration with jens-maus in https://github.com/jens-maus/RaspberryMatic/pull/1847) There have been zero other instances of this error reported since the release of lighttpd 1.4.56 in Nov 2020. Therefore, having ssl.engine = "enable" inherited from the global scope is unlikely to have any widespread impact in practice, and enabling ssl.engine = "enable" (along with TLS certificate configuration) is now recommended as default. When ssl.engine = "enable" in the global scope, ssl.engine = "disable" should be specified in those $SERVER["socket"] conditions where clear-text is desired.
* [multiple] simplify bytes_in/bytes_out accountingGlenn Strauss2022-05-111-6/+1
| | | | | | | | | | | | | | | | encapsulate accounting calculations in http_request_stats_bytes_in() http_request_stats_bytes_out() more accurate accounting for HTTP/1.1 bytes_in on keep-alive requests (affects case where client pipelines HTTP/1.1 requests) remove con->bytes_read and con->bytes_written (no longer needed since request_st was split from connection struct and request bytes_read_ckpt and bytes_written_ckpt are maintained for HTTP/1.x bytes_in and bytes_out accounting. Also, further back, chunkqueue internal accounting was simplified to maintain bytes_in and bytes_out to always match chunkqueue length)
* [multiple] reset http vers, avoid rare crash (fixes #3152)Glenn Strauss2022-05-051-1/+2
| | | | | | | | | | | | | | | (thx ultimator) do not set r->http_version to HTTP_VERSION_2 when selecting TLS ALPN if r->handler_module already set, since handler module is likely mod_sockproxy, and con->h2 will not get initialized. This does continue to select "h2", so the mod_sockproxy backend should be prepared to receive the HTTP/2 client connection preface. x-ref: "Random Segfaults with version 1.4.64 w/ mod_sockproxy and ALPN h2" https://redmine.lighttpd.net/issues/3152
* [multiple] limit scope of socket config optionsGlenn Strauss2022-05-051-9/+9
| | | | | warn if socket config options used only at startup are used outside global scope or $SERVER["socket"] with '==' condition
* [TLS] warn if leaf cert read is inactive/expiredGlenn Strauss2022-03-281-2/+36
| | | | | | | When reading certificates, warn if leaf certificate is inactive/expired (according to notBefore, notAfter fields of leaf certificate) (note: not adding a delta for fudge factor when comparing times) (note: not currently verifying each certificate in chain)
* [mod_openssl] libressl v3.5.0 adds ASN1_TIME_diffGlenn Strauss2022-03-271-2/+2
|
* [mod_openssl] do not esc UTF-8 in cert subjectGlenn Strauss2022-01-171-1/+2
| | | | | | | | | unset flag which escapes chars with most-significant-bit set for clean display of non-ASCII UTF-8 chars in cert subject x-ref: man X509_NAME_oneline man ASN1_STRING_print_ex
* [build] feature consistency between build typesGlenn Strauss2022-01-031-1/+1
| | | | | upate config.h.cmake for missing defines minor adjustments to other builds for features consistency
* [core] add remote IP to some error msgs (fixes #3122)Glenn Strauss2021-12-091-2/+4
| | | | | | | | add remote IP to some select error msgs x-ref: "Error messages should include client IP" https://redmine.lighttpd.net/issues/3122
* [mod_openssl] boringssl compatGlenn Strauss2021-10-031-0/+3
|
* [multiple] clarify error msg when no cert availGlenn Strauss2021-10-011-1/+1
|
* [multiple] check feature flags funcs; code reuseGlenn Strauss2021-09-301-4/+1
| | | | | config_feature_bool() config_feature_int()
* [mod_openssl] default disable client renegotiationGlenn Strauss2021-09-081-0/+2
|
* [mod_openssl] no ALPN fatal error w/ mod_sockproxy (fixes #3081)Glenn Strauss2021-09-041-1/+3
| | | | | | | | | | | If mod_sockproxy -- or other connection-level handler -- has been set on the request prior to mod_openssl processing TLS Client Hello, then failure to match ALPN protocol is no longer treated as a TLS connection setup error. x-ref: "sockproxy: Do not validate ALPN protocols" https://redmine.lighttpd.net/issues/3081
* [multiple] Y2038 32-bit signed time_t mitigationsGlenn Strauss2021-09-041-34/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most OS platforms have already provided solutions to Y2038 32-bit signed time_t 5 - 10 years ago (or more!) Notable exceptions are Linux i686 and FreeBSD i386. Since 32-bit systems tend to be embedded systems, and since many distros take years to pick up new software, this commit aims to provide Y2038 mitigations for lighttpd running on 32-bit systems with Y2038-unsafe 32-bit signed time_t * Y2038: lighttpd 1.4.60 and later report Y2038 safety $ lighttpd -V + Y2038 support # Y2038-SAFE $ lighttpd -V - Y2038 support (unsafe 32-bit signed time_t) # Y2038-UNSAFE * Y2038: general platform info * Y2038-SAFE: lighttpd 64-bit builds on platforms using 64-bit time_t - all major 64-bit platforms (known to this author) use 64-bit time_t * Y2038-SAFE: lighttpd 32-bit builds on platforms using 64-bit time_t - Linux x32 ABI (different from i686) - FreeBSD all 32-bit and 64-bit architectures *except* 32-bit i386 - NetBSD 6.0 (released Oct 2012) all 32-bit and 64-bit architectures - OpenBSD 5.5 (released May 2014) all 32-bit and 64-bit architectures - Microsoft Windows XP and Visual Studio 2005 (? unsure ?) Another reference suggests Visual Studio 2015 defaults to 64-bit time_t - MacOS 10.15 Catalina (released 2019) drops support for 32-bit apps * Y2038-SAFE: lighttpd 32-bit builds on platforms using 32-bit unsigned time_t - e.g. OpenVMS (unknown if lighttpd builds on this platform) * Y2038-UNSAFE: lighttpd 32-bit builds on platforms using 32-bit signed time_t - Linux 32-bit (including i686) - glibc 32-bit library support not yet available for 64-bit time_t - https://sourceware.org/glibc/wiki/Y2038ProofnessDesign - Linux kernel 5.6 on 32-bit platforms does support 64-bit time_t https://itsubuntu.com/linux-kernel-5-6-to-fix-the-year-2038-issue-unix-y2k/ - https://www.gnu.org/software/libc/manual/html_node/64_002dbit-time-symbol-handling.html "Note: at this point, 64-bit time support in dual-time configurations is work-in-progress, so for these configurations, the public API only makes the 32-bit time support available. In a later change, the public API will allow user code to choose the time size for a given compilation unit." - compiling with -D_TIME_BITS=64 currently has no effect - glibc recent (Jul 2021) mailing list discussion - https://public-inbox.org/bug-gnulib/878s2ozq70.fsf@oldenburg.str.redhat.com/T/ - FreeBSD i386 - DragonFlyBSD 32-bit * Y2038 mitigations attempted on Y2038-UNSAFE platforms (32-bit signed time_t) * lighttpd prefers system monotonic clock instead of realtime clock in places where realtime clock is not required * lighttpd treats negative time_t values as after 19 Jan 2038 03:14:07 GMT * (lighttpd presumes that lighttpd will not encounter dates before 1970 during normal operation.) * lighttpd casts struct stat st.st_mtime (and st.st_*time) through uint64_t to convert negative timestamps for comparisions with 64-bit timestamps (treating negative timestamp values as after 19 Jan 2038 03:14:07 GMT) * lighttpd provides unix_time64_t (int64_t) and * lighttpd provides struct unix_timespec64 (unix_timespec64_t) (struct timespec equivalent using unix_time64_t tv_sec member) * lighttpd provides gmtime64_r() and localtime64_r() wrappers for platforms 32-bit platforms using 32-bit time_t and lighttpd temporarily shifts the year in order to use gmtime_r() and localtime_r() (or gmtime() and localtime()) from standard libraries, before readjusting year and passing struct tm to formatting functions such as strftime() * lighttpd provides TIME64_CAST() macro to cast signed 32-bit time_t to unsigned 32-bit and then to unix_time64_t * Note: while lighttpd tries handle times past 19 Jan 2038 03:14:07 GMT on 32-bit platforms using 32-bit signed time_t, underlying libraries and underlying filesystems might not behave properly after 32-bit signed time_t overflows (19 Jan 2038 03:14:08 GMT). If a given 32-bit OS does not work properly using negative time_t values, then lighttpd likely will not work properly on that system. * Other references and blogs - https://en.wikipedia.org/wiki/Year_2038_problem - https://en.wikipedia.org/wiki/Time_formatting_and_storage_bugs - http://www.lieberbiber.de/2017/03/14/a-look-at-the-year-20362038-problems-and-time-proofness-in-various-systems/
* [multiple] buffer_copy_string_len_lc()Glenn Strauss2021-08-271-2/+1
| | | | | | | convenience wrapper combining buffer_copy_string_len() buffer_to_lower() and making a single pass over string
* [multiple] reduce redundant NULL buffer checksGlenn Strauss2021-08-271-43/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is a large set of code changes and results in removal of hundreds, perhaps thousands, of CPU instructions, a portion of which are on hot code paths. Most (buffer *) used by lighttpd are not NULL, especially since buffers were inlined into numerous larger structs such as request_st and chunk. In the small number of instances where that is not the case, a NULL check is often performed earlier in a function where that buffer is later used with a buffer_* func. In the handful of cases that remained, a NULL check was added, e.g. with r->http_host and r->conf.server_tag. - check for empty strings at config time and set value to NULL if blank string will be ignored at runtime; at runtime, simple pointer check for NULL can be used to check for a value that has been set and is not blank ("") - use buffer_is_blank() instead of buffer_string_is_empty(), and use buffer_is_unset() instead of buffer_is_empty(), where buffer is known not to be NULL so that NULL check can be skipped - use buffer_clen() instead of buffer_string_length() when buffer is known not to be NULL (to avoid NULL check at runtime) - use buffer_truncate() instead of buffer_string_set_length() to truncate string, and use buffer_extend() to extend Examples where buffer known not to be NULL: - cpv->v.b from config_plugin_values_init is not NULL if T_CONFIG_BOOL (though we might set it to NULL if buffer_is_blank(cpv->v.b)) - address of buffer is arg (&foo) (compiler optimizer detects this in most, but not all, cases) - buffer is checked for NULL earlier in func - buffer is accessed in same scope without a NULL check (e.g. b->ptr) internal behavior change: callers must not pass a NULL buffer to some funcs. - buffer_init_buffer() requires non-null args - buffer_copy_buffer() requires non-null args - buffer_append_string_buffer() requires non-null args - buffer_string_space() requires non-null arg
* [TLS] reset stek_rotate_ts if clock moves backwardGlenn Strauss2021-08-271-0/+5
| | | | | | | | reset stek_rotate_ts if clock moves backwards > 28800 seconds x-ref: "Lighttpd 1.4.58 SSL connections stop working if system time of lighttpd server is changed to future one (+12h or even days)" https://redmine.lighttpd.net/issues/3080
* [TLS] write_cq_ssl defer remove_finished_chunksGlenn Strauss2021-08-271-10/+14
| | | | | | not expecting 0-length chunks, but handle within loops as cold path mark some cold paths in read_cq_ssl and write_cq_ssl callback funcs
* [mod_auth*] rename http_auth.* -> mod_auth_api.*Glenn Strauss2021-08-271-1/+1
| | | | rename http_auth.[ch] -> mod_auth_api.[ch]
* [multiple] rename safe_memclear() -> ck_memzero()Glenn Strauss2021-08-271-4/+4
|
* [multiple] use thread-safe strerror where availGlenn Strauss2021-08-271-2/+3
| | | | | use ck_strerror_s() to use strerror_s() or strerror_r() thread-safe and constraint-checking interfaces, where available.
* [multiple] mark con->srv_socket a const ptrGlenn Strauss2021-05-131-1/+1
|
* [TLS] ALPN h2 policyGlenn Strauss2021-05-061-1/+36
| | | | | | | | | | | | | | | | | | | HTTP/2 requires that TLS protocol >= TLSv1.2 HTTP/2 requires that TLS record compression be disabled HTTP/2 requires that TLSv1.2 renegotiation be disabled HTTP/2 requires that TLS SNI extension be presented with ALPN h2 (not enforced; SNI omitted by client when connecting to IP instead of to name) RFC 7540 9.2 Use of TLS Features "Implementations are encouraged to provide defaults that comply, but it is recognized that deployments are ultimately responsible for compliance." If TLS record compression or renegotiation are for some reason required (which is strongly discouraged), then disable HTTP/2 in lighttpd with server.feature-flags = ("server.h2proto" => "disable")
* [core] move timegm() impl inline in sys-time.hGlenn Strauss2021-04-261-1/+2
| | | | (for systems without timegm())
* [mod_openssl] issue error trace if < openssl 1.1.1Glenn Strauss2021-04-061-0/+8
|
* [TLS] rename ssl.verifyclient.ca-*file optionsGlenn Strauss2021-04-061-5/+39
| | | | | | | | | rename to reflect use for verifying client certificate (old names are still accepted, but are discouraged) ssl.ca-file -> ssl.verifyclient.ca-file ssl.ca-dn-file -> ssl.verifyclient.ca-dn-file ssl.ca-crl-file -> ssl.verifyclient.ca-crl-file
* [multiple] buffer_copy_path_len2() aggregateGlenn Strauss2021-04-021-2/+2
|
* [multiple] pass len when copying constant stringsGlenn Strauss2021-04-021-2/+2
|
* [TLS] use stack for SSL_CLIENT_S_DN_* tagGlenn Strauss2021-03-261-6/+6
| | | | (reduce use of r->tmp_buf in TLS modules)
* [TLS] https_add_ssl_client_verify_err()Glenn Strauss2021-03-261-3/+12
| | | | | | separate routine for printing client certificate verification error more consistent SSL_CLIENT_M_SERIAL between modules
* [multiple] http_header APIs to reduce str copiesGlenn Strauss2021-03-261-39/+37
|
View Lorry Controller Status