summaryrefslogtreecommitdiff
path: root/src/mod_ssi.c
Commit message (Collapse)AuthorAgeFilesLines
* [build] _WIN32 __declspec(dllexport) *_plugin_initGlenn Strauss2023-05-031-0/+1
| | | | _WIN32 __declspec(dllexport) on mod_*_plugin_init()
* [multiple] __MINGW32__ missing strftime() "%F %T"Glenn Strauss2023-05-031-1/+6
| | | | mingw does not support strftime() "%F %T"
* [core] _WIN32 sys-wait.h to wrap <sys/wait.h>Glenn Strauss2023-05-031-3/+1
|
* [core] _WIN32 sys-unistd.h to wrap <unistd.h>Glenn Strauss2023-05-031-1/+1
| | | | (selective implementations; not complete)
* [multiple] employ ck_calloc, ck_malloc shared codeGlenn Strauss2022-12-101-9/+3
| | | | | employ ck_calloc(), ck_malloc() shared code to slightly reduce code size (centralize the ck_assert() to check that memory allocation succeeded)
* [multiple] mark mod_*_plugin_init() funcs coldGlenn Strauss2022-12-071-0/+1
|
* [multiple] use buffer_append_char()Glenn Strauss2022-05-111-2/+2
|
* [mod_ssi] check http_chunk_transfer_cqlen for errGlenn Strauss2022-03-251-2/+6
| | | | pedantic check of http_chunk_transfer_cqlen() for error
* [multiple] remove r->physical.etagGlenn Strauss2021-12-121-2/+2
| | | | (no longer used; was used as temporary buffer)
* [core] isolate use of sys/filio.hGlenn Strauss2021-12-021-4/+0
| | | | | isolate use of sys/filio.h to fdevent_ioctl_fionread() (illumos (OpenIndiana) defines FIONREAD in sys/filio.h)
* [mod_ssi] merge mod_ssi_expr.c into mod_ssi.cGlenn Strauss2021-11-121-2/+372
| | | | isolate this ancient relic
* [multiple] avoid empty chunks in chunkqueueGlenn Strauss2021-09-301-9/+6
| | | | | (This might render some calls to chunkqueue_remove_finished_chunks() no longer necessary)
* [multiple] de-dup file and piped loggers (fixes #3101)Glenn Strauss2021-09-131-1/+2
| | | | | | | | de-dup file and piped loggers for error logs and access logs x-ref: "RFE: de-dup file and piped loggers" https://redmine.lighttpd.net/issues/3101
* [multiple] remove base.h include where not usedGlenn Strauss2021-09-081-1/+1
| | | | | (substitute request.h if file only accesses request_st, and not connection or server structs)
* [multiple] Y2038 32-bit signed time_t mitigationsGlenn Strauss2021-09-041-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most OS platforms have already provided solutions to Y2038 32-bit signed time_t 5 - 10 years ago (or more!) Notable exceptions are Linux i686 and FreeBSD i386. Since 32-bit systems tend to be embedded systems, and since many distros take years to pick up new software, this commit aims to provide Y2038 mitigations for lighttpd running on 32-bit systems with Y2038-unsafe 32-bit signed time_t * Y2038: lighttpd 1.4.60 and later report Y2038 safety $ lighttpd -V + Y2038 support # Y2038-SAFE $ lighttpd -V - Y2038 support (unsafe 32-bit signed time_t) # Y2038-UNSAFE * Y2038: general platform info * Y2038-SAFE: lighttpd 64-bit builds on platforms using 64-bit time_t - all major 64-bit platforms (known to this author) use 64-bit time_t * Y2038-SAFE: lighttpd 32-bit builds on platforms using 64-bit time_t - Linux x32 ABI (different from i686) - FreeBSD all 32-bit and 64-bit architectures *except* 32-bit i386 - NetBSD 6.0 (released Oct 2012) all 32-bit and 64-bit architectures - OpenBSD 5.5 (released May 2014) all 32-bit and 64-bit architectures - Microsoft Windows XP and Visual Studio 2005 (? unsure ?) Another reference suggests Visual Studio 2015 defaults to 64-bit time_t - MacOS 10.15 Catalina (released 2019) drops support for 32-bit apps * Y2038-SAFE: lighttpd 32-bit builds on platforms using 32-bit unsigned time_t - e.g. OpenVMS (unknown if lighttpd builds on this platform) * Y2038-UNSAFE: lighttpd 32-bit builds on platforms using 32-bit signed time_t - Linux 32-bit (including i686) - glibc 32-bit library support not yet available for 64-bit time_t - https://sourceware.org/glibc/wiki/Y2038ProofnessDesign - Linux kernel 5.6 on 32-bit platforms does support 64-bit time_t https://itsubuntu.com/linux-kernel-5-6-to-fix-the-year-2038-issue-unix-y2k/ - https://www.gnu.org/software/libc/manual/html_node/64_002dbit-time-symbol-handling.html "Note: at this point, 64-bit time support in dual-time configurations is work-in-progress, so for these configurations, the public API only makes the 32-bit time support available. In a later change, the public API will allow user code to choose the time size for a given compilation unit." - compiling with -D_TIME_BITS=64 currently has no effect - glibc recent (Jul 2021) mailing list discussion - https://public-inbox.org/bug-gnulib/878s2ozq70.fsf@oldenburg.str.redhat.com/T/ - FreeBSD i386 - DragonFlyBSD 32-bit * Y2038 mitigations attempted on Y2038-UNSAFE platforms (32-bit signed time_t) * lighttpd prefers system monotonic clock instead of realtime clock in places where realtime clock is not required * lighttpd treats negative time_t values as after 19 Jan 2038 03:14:07 GMT * (lighttpd presumes that lighttpd will not encounter dates before 1970 during normal operation.) * lighttpd casts struct stat st.st_mtime (and st.st_*time) through uint64_t to convert negative timestamps for comparisions with 64-bit timestamps (treating negative timestamp values as after 19 Jan 2038 03:14:07 GMT) * lighttpd provides unix_time64_t (int64_t) and * lighttpd provides struct unix_timespec64 (unix_timespec64_t) (struct timespec equivalent using unix_time64_t tv_sec member) * lighttpd provides gmtime64_r() and localtime64_r() wrappers for platforms 32-bit platforms using 32-bit time_t and lighttpd temporarily shifts the year in order to use gmtime_r() and localtime_r() (or gmtime() and localtime()) from standard libraries, before readjusting year and passing struct tm to formatting functions such as strftime() * lighttpd provides TIME64_CAST() macro to cast signed 32-bit time_t to unsigned 32-bit and then to unix_time64_t * Note: while lighttpd tries handle times past 19 Jan 2038 03:14:07 GMT on 32-bit platforms using 32-bit signed time_t, underlying libraries and underlying filesystems might not behave properly after 32-bit signed time_t overflows (19 Jan 2038 03:14:08 GMT). If a given 32-bit OS does not work properly using negative time_t values, then lighttpd likely will not work properly on that system. * Other references and blogs - https://en.wikipedia.org/wiki/Year_2038_problem - https://en.wikipedia.org/wiki/Time_formatting_and_storage_bugs - http://www.lieberbiber.de/2017/03/14/a-look-at-the-year-20362038-problems-and-time-proofness-in-various-systems/
* [multiple] reduce redundant NULL buffer checksGlenn Strauss2021-08-271-33/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is a large set of code changes and results in removal of hundreds, perhaps thousands, of CPU instructions, a portion of which are on hot code paths. Most (buffer *) used by lighttpd are not NULL, especially since buffers were inlined into numerous larger structs such as request_st and chunk. In the small number of instances where that is not the case, a NULL check is often performed earlier in a function where that buffer is later used with a buffer_* func. In the handful of cases that remained, a NULL check was added, e.g. with r->http_host and r->conf.server_tag. - check for empty strings at config time and set value to NULL if blank string will be ignored at runtime; at runtime, simple pointer check for NULL can be used to check for a value that has been set and is not blank ("") - use buffer_is_blank() instead of buffer_string_is_empty(), and use buffer_is_unset() instead of buffer_is_empty(), where buffer is known not to be NULL so that NULL check can be skipped - use buffer_clen() instead of buffer_string_length() when buffer is known not to be NULL (to avoid NULL check at runtime) - use buffer_truncate() instead of buffer_string_set_length() to truncate string, and use buffer_extend() to extend Examples where buffer known not to be NULL: - cpv->v.b from config_plugin_values_init is not NULL if T_CONFIG_BOOL (though we might set it to NULL if buffer_is_blank(cpv->v.b)) - address of buffer is arg (&foo) (compiler optimizer detects this in most, but not all, cases) - buffer is checked for NULL earlier in func - buffer is accessed in same scope without a NULL check (e.g. b->ptr) internal behavior change: callers must not pass a NULL buffer to some funcs. - buffer_init_buffer() requires non-null args - buffer_copy_buffer() requires non-null args - buffer_append_string_buffer() requires non-null args - buffer_string_space() requires non-null arg
* [core] simplify buffer_path_simplify()Glenn Strauss2021-05-081-2/+2
|
* [core] remove buffer_is_equal_right_len()Glenn Strauss2021-05-071-6/+6
| | | | (not widely used or widely useful)
* [multiple] static file optimization; reuse cacheGlenn Strauss2021-05-061-1/+2
| | | | | | reuse cache lookup in common case of serving a static file rather than repeating the stat_cache_entry lookup (which is more work than memcmp() to re-check stat_cache_entry match)
* [multiple] buffer_copy_path_len2() aggregateGlenn Strauss2021-04-021-9/+15
|
* [multiple] use buffer_append_* aggregatesGlenn Strauss2021-04-021-9/+6
| | | | reduces the number of round-trips into some frequently-called routines
* [mod_ssi] use intermediate chunkqueue to aggregateGlenn Strauss2021-04-021-6/+17
| | | | | | | periodically flush intermediate chunkqueue to r->write_queue to reduce occurrence of copying to reallocate larger chunk use chunk_buffer to read ssi file
* [mod_ssi] shared code to wrap strftime()Glenn Strauss2021-04-021-28/+21
|
* [multiple] strftime %F and %TGlenn Strauss2021-04-021-1/+1
| | | | strftime %F for %Y-%m-%d, and %T for %H:%M:%S
* [mod_ssi] inline some buffers in ssi plugin_dataGlenn Strauss2021-03-261-11/+15
|
* [multiple] do not clear physical.path if finishedGlenn Strauss2021-03-261-3/+0
| | | | | | do not reset r->physical.path (unneeded) if returning HANDLER_FINISHED error handler will reset r->physical.path, if necessary
* [multiple] add attrs from gcc -Wsuggest-attribute=Glenn Strauss2021-03-261-0/+1
|
* [core] http_cgi.[ch] CGI interfaces (RFC 3875)Glenn Strauss2021-03-071-0/+1
| | | | collect Common Gateway Interface (CGI) interfaces (RFC 3875)
* [multiple] etag.[ch] -> http_etag.[ch]; better impGlenn Strauss2020-12-251-4/+2
| | | | | | more efficient implementation of HTTP ETag generation and comparison modify dekhash() to take hash value to allow for incremental hashing
* buffer_append_path_len() to join pathsGlenn Strauss2020-12-241-13/+8
| | | | use buffer_append_path_len() to join path segments
* [multiple] employ http_date.h, sys-time.hGlenn Strauss2020-12-241-37/+24
| | | | | - replace use of strptime() w/ implementation specialized for HTTP dates - use thread-safe gmtime_r(), localtime_r() (replace localtime, gmtime)
* [multiple] fdevent_waitpid() wrapperGlenn Strauss2020-12-241-5/+5
|
* [mod_ssi] use stat_cache_open_rdonly_fstat()Glenn Strauss2020-10-111-8/+1
|
* [multiple] inline chunkqueue where always alloc'dGlenn Strauss2020-10-111-4/+4
| | | | | | inline struct chunkqueue where always allocated in other structs (memory locality)
* [mod_ssi] init status var before waitpid()Glenn Strauss2020-10-111-1/+1
|
* [mod_ssi] update chunk after shell output redirectGlenn Strauss2020-10-111-1/+1
| | | | | chunkqueue_update_file() to update size of file chunk after redirecting shell output to file fd
* [multiple] rename connection_reset hook to requestGlenn Strauss2020-08-021-2/+2
| | | | rename connection_reset to handle_request_reset
* [multiple] use *(unsigned char *) with ctypesGlenn Strauss2020-07-081-3/+3
|
* [multiple] split con, request (very large change)Glenn Strauss2020-07-081-157/+164
| | | | | | | | | | | | | | | | NB: r->tmp_buf == srv->tmp_buf (pointer is copied for quicker access) NB: request read and write chunkqueues currently point to connection chunkqueues; per-request and per-connection chunkqueues are not distinct from one another con->read_queue == r->read_queue con->write_queue == r->write_queue NB: in the future, a separate connection config may be needed for connection-level module hooks. Similarly, might need to have per-request chunkqueues separate from per-connection chunkqueues. Should probably also have a request_reset() which is distinct from connection_reset().
* [core] store subrequest_handler instead of modeGlenn Strauss2020-07-081-4/+3
| | | | store pointer to module in handler_module instead of con->mode id
* [core] move plugin_ctx into (request_st *)Glenn Strauss2020-07-081-4/+4
| | | | | NB: in the future, a separate plugin_ctx may be needed for connection-level plugins to keep state across multiple requests
* [core] move addtl request-specific struct membersGlenn Strauss2020-07-081-2/+2
|
* [core] move addtl request-specific struct membersGlenn Strauss2020-07-081-2/+2
|
* [core] support multiple error logsGlenn Strauss2020-07-081-1/+2
| | | | | | | e.g. different server.errorlog for different virtual hosts Also, support different server.breakagelog to have separate script error logs, applicable to mod_cgi and mod_ssi exec.
* [core] static buffers for mtime_cacheGlenn Strauss2020-07-081-1/+1
|
* [multiple] generic config array type checkingGlenn Strauss2020-07-081-26/+1
|
* [multiple] stat_cache singletonGlenn Strauss2020-07-081-1/+1
|
* [multiple] connection hooks no longer get (srv *)Glenn Strauss2020-07-081-4/+1
| | | | (explicit (server *) not passed; available in con->srv)
* [multiple] prefer (connection *) to (srv *)Glenn Strauss2020-07-081-127/+115
| | | | | | | | convert all log_error_write() to log_error() and pass (log_error_st *) use con->errh in preference to srv->errh (even though currently same) avoid passing (server *) when previously used only for logging (errh)
* [core] array_init() arg for initial sizeGlenn Strauss2020-07-081-2/+2
|
View Lorry Controller Status