diff options
| author | Ezequiel Garcia <ezequiel.garcia@free-electrons.com> | 2013-03-21 17:42:07 -0300 |
|---|---|---|
| committer | Zhang Rui <rui.zhang@intel.com> | 2013-03-26 22:09:14 +0800 |
| commit | 02519d3397b57bf723f6df69c92b0b66ecafb11a (patch) | |
| tree | 2a3c05e2ce9fd1aba52325fa567edd0535b5540b | |
| parent | f8b587055a793c7719f0d4f41b7b4aeeef43aa2d (diff) | |
| download | linux-next-02519d3397b57bf723f6df69c92b0b66ecafb11a.tar.gz | |
thermal: kirkwood: Fix valid check for thermal register
The correct value is obtain by first shifting the register by the offset,
later applying the valid mask and finally invert the result.
This check was lacking an extra parenthesis to be strictly correct.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
| -rw-r--r-- | drivers/thermal/kirkwood_thermal.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/thermal/kirkwood_thermal.c b/drivers/thermal/kirkwood_thermal.c index e5500edb5285..d2e05eec722a 100644 --- a/drivers/thermal/kirkwood_thermal.c +++ b/drivers/thermal/kirkwood_thermal.c @@ -41,8 +41,8 @@ static int kirkwood_get_temp(struct thermal_zone_device *thermal, reg = readl_relaxed(priv->sensor); /* Valid check */ - if (!(reg >> KIRKWOOD_THERMAL_VALID_OFFSET) & - KIRKWOOD_THERMAL_VALID_MASK) { + if (!((reg >> KIRKWOOD_THERMAL_VALID_OFFSET) & + KIRKWOOD_THERMAL_VALID_MASK)) { dev_err(&thermal->device, "Temperature sensor reading not valid\n"); return -EIO; |