diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2016-05-24 10:03:59 +1000 |
---|---|---|
committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2016-05-24 15:27:54 +1000 |
commit | 57b6315620d5b0fa8743883990ca3b497b51b6bf (patch) | |
tree | e77d38fc397f5bbaa6e6c80dbf468487c3e6c84f | |
parent | 4421cfdb3fdefdce68127693592bea17458415ff (diff) | |
download | linux-next-57b6315620d5b0fa8743883990ca3b497b51b6bf.tar.gz |
mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes
WARNING: Missing a blank line after declarations
#34: FILE: include/linux/page_idle.h:50:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#45: FILE: include/linux/page_idle.h:60:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#57: FILE: include/linux/page_idle.h:70:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#68: FILE: include/linux/page_idle.h:80:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#79: FILE: include/linux/page_idle.h:90:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
WARNING: Missing a blank line after declarations
#90: FILE: include/linux/page_idle.h:100:
+ struct page_ext *page_ext;
+ page_ext = lookup_page_ext(page);
total: 1 errors, 6 warnings, 196 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Yang Shi <yang.shi@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r-- | include/linux/page_idle.h | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/include/linux/page_idle.h b/include/linux/page_idle.h index 8f5d4ad34371..569c3a180625 100644 --- a/include/linux/page_idle.h +++ b/include/linux/page_idle.h @@ -46,8 +46,8 @@ extern struct page_ext_operations page_idle_ops; static inline bool page_is_young(struct page *page) { - struct page_ext *page_ext; - page_ext = lookup_page_ext(page); + struct page_ext *page_ext = lookup_page_ext(page); + if (unlikely(!page_ext) return false; @@ -56,8 +56,8 @@ static inline bool page_is_young(struct page *page) static inline void set_page_young(struct page *page) { - struct page_ext *page_ext; - page_ext = lookup_page_ext(page); + struct page_ext *page_ext = lookup_page_ext(page); + if (unlikely(!page_ext) return; @@ -66,8 +66,8 @@ static inline void set_page_young(struct page *page) static inline bool test_and_clear_page_young(struct page *page) { - struct page_ext *page_ext; - page_ext = lookup_page_ext(page); + struct page_ext *page_ext = lookup_page_ext(page); + if (unlikely(!page_ext) return false; @@ -76,8 +76,8 @@ static inline bool test_and_clear_page_young(struct page *page) static inline bool page_is_idle(struct page *page) { - struct page_ext *page_ext; - page_ext = lookup_page_ext(page); + struct page_ext *page_ext = lookup_page_ext(page); + if (unlikely(!page_ext) return false; @@ -86,8 +86,8 @@ static inline bool page_is_idle(struct page *page) static inline void set_page_idle(struct page *page) { - struct page_ext *page_ext; - page_ext = lookup_page_ext(page); + struct page_ext *page_ext = lookup_page_ext(page); + if (unlikely(!page_ext) return; @@ -96,8 +96,8 @@ static inline void set_page_idle(struct page *page) static inline void clear_page_idle(struct page *page) { - struct page_ext *page_ext; - page_ext = lookup_page_ext(page); + struct page_ext *page_ext = lookup_page_ext(page); + if (unlikely(!page_ext) return; |