summaryrefslogtreecommitdiff
path: root/drivers/ata/pata_falcon.c
diff options
context:
space:
mode:
authorEdgar Cherkasov <echerkasov@dev.rtsoft.ru>2017-04-04 19:18:27 +0300
committerWolfram Sang <wsa@the-dreams.de>2017-04-16 21:48:06 +0200
commite058e7a4bc89104540a8a303682248614b5df6f1 (patch)
tree89a631c08c118984da4e9c743266f4a38ef9942a /drivers/ata/pata_falcon.c
parent69e620f866c983d59d7d41d74a08d39528161473 (diff)
downloadlinux-next-e058e7a4bc89104540a8a303682248614b5df6f1.tar.gz
i2c: i2c-scmi: add a MS HID
Description of the problem: - i2c-scmi driver contains only two identifiers "SMBUS01" and "SMBUSIBM"; - the fist HID (SMBUS01) is clearly defined in "SMBus Control Method Interface Specification, version 1.0": "Each device must specify 'SMBUS01' as its _HID and use a unique _UID value"; - unfortunately, BIOS vendors (like AMI) seem to ignore this requirement and implement "SMB0001" HID instead of "SMBUS01"; - I speculate that they do this because only "SMB0001" is hard coded in Windows SMBus driver produced by Microsoft. This leads to following situation: - SMBus works out of box in Windows but not in Linux; - board vendors are forced to add correct "SMBUS01" HID to BIOS to make SMBus work in Linux. Moreover the same board vendors complain that tools (3-rd party ASL compiler) do not like the "SMBUS01" identifier and produce errors. So they need to constantly patch the compiler for each new version of BIOS. As it is very unlikely that BIOS vendors implement a correct HID in future, I would propose to consider whether it is possible to work around the problem by adding MS HID to the Linux i2c-scmi driver. v2: move the definition of the new HID to the driver itself. Signed-off-by: Edgar Cherkasov <echerkasov@dev.rtsoft.ru> Signed-off-by: Michael Brunner <Michael.Brunner@kontron.com> Acked-by: Viktor Krasnov <vkrasnov@dev.rtsoft.ru> Reviewed-by: Jean Delvare <jdelvare@suse.de> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/ata/pata_falcon.c')
0 files changed, 0 insertions, 0 deletions