diff options
| author | Sumera Priyadarsini <sylphrenadin@gmail.com> | 2020-08-25 01:33:11 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-08-25 07:44:41 -0700 |
| commit | 8e4efd4706f77d76c99f78f8859e1d61fae5142a (patch) | |
| tree | 2fb1e0cf3eb4d4bb6bbc26fa22edbb314b57d740 /drivers/net/dsa/mt7530.c | |
| parent | b274e47d9e3f4dcd4ad4028a316ec22dc4533ac7 (diff) | |
| download | linux-next-8e4efd4706f77d76c99f78f8859e1d61fae5142a.tar.gz | |
net: dsa: mt7530: Add of_node_put() before break and return statements
Every iteration of for_each_child_of_node() decrements
the reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.
Fix a potential memory leak in mt7530.c by inserting of_node_put()
before the break and return statements.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/mt7530.c')
| -rw-r--r-- | drivers/net/dsa/mt7530.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 8dcb8a49ab67..4b4701c69fe1 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -1326,14 +1326,17 @@ mt7530_setup(struct dsa_switch *ds) if (phy_node->parent == priv->dev->of_node->parent) { ret = of_get_phy_mode(mac_np, &interface); - if (ret && ret != -ENODEV) + if (ret && ret != -ENODEV) { + of_node_put(mac_np); return ret; + } id = of_mdio_parse_addr(ds->dev, phy_node); if (id == 0) priv->p5_intf_sel = P5_INTF_SEL_PHY_P0; if (id == 4) priv->p5_intf_sel = P5_INTF_SEL_PHY_P4; } + of_node_put(mac_np); of_node_put(phy_node); break; } |