diff options
| author | Auke Kok <auke\-jan.h.kok@intel.com> | 2006-09-27 12:53:17 -0700 |
|---|---|---|
| committer | Auke Kok <juke-jan.h.kok@intel.com> | 2006-09-27 12:53:17 -0700 |
| commit | 0eb5a34cdf34ad07b6db2df1e523aaf6574601b4 (patch) | |
| tree | 75d2086eb9601bb2374b0d7575b12484ed189748 /drivers/net/e1000 | |
| parent | 0abb6eb12806cf99ea815810d470423083c3b9f4 (diff) | |
| download | linux-next-0eb5a34cdf34ad07b6db2df1e523aaf6574601b4.tar.gz | |
e100, e1000, ixgb: Fix an impossible memory overwrite bug
We keep getting requests from people that think that this might be
an exploitable hole where we would overwrite 4 bytes in the netdev
struct if the pci name would exceed 15 characters. In reality this
will never happen but we fix it anyway.
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Diffstat (limited to 'drivers/net/e1000')
| -rw-r--r-- | drivers/net/e1000/e1000_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 082c02918a41..bd673802e8ce 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -759,7 +759,7 @@ e1000_probe(struct pci_dev *pdev, #ifdef CONFIG_NET_POLL_CONTROLLER netdev->poll_controller = e1000_netpoll; #endif - strcpy(netdev->name, pci_name(pdev)); + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); netdev->mem_start = mmio_start; netdev->mem_end = mmio_start + mmio_len; |