summaryrefslogtreecommitdiff
path: root/drivers/usb/misc
diff options
context:
space:
mode:
authorOliver Neukum <oneukum@suse.com>2017-03-14 12:05:07 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-03-16 18:01:02 +0900
commitc4ba329cabca7c839ab48fb58b5bcc2582951a48 (patch)
treeb04794ac64f6884a77d2fab730266f95cb085963 /drivers/usb/misc
parente4ecd155d2a62246fc7722aeaa5819262904f40b (diff)
downloadlinux-next-c4ba329cabca7c839ab48fb58b5bcc2582951a48.tar.gz
usb: misc: lvs: fix race condition in disconnect handling
There is a small window during which the an URB may remain active after disconnect has returned. If in that case already freed memory may be accessed and executed. The fix is to poison the URB befotre the work is flushed. Signed-off-by: Oliver Neukum <oneukum@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/misc')
-rw-r--r--drivers/usb/misc/lvstest.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c
index c7c210421217..b7fc978724de 100644
--- a/drivers/usb/misc/lvstest.c
+++ b/drivers/usb/misc/lvstest.c
@@ -429,6 +429,7 @@ static void lvs_rh_disconnect(struct usb_interface *intf)
struct lvs_rh *lvs = usb_get_intfdata(intf);
sysfs_remove_group(&intf->dev.kobj, &lvs_attr_group);
+ usb_poison_urb(lvs->urb); /* used in scheduled work */
flush_work(&lvs->rh_work);
usb_free_urb(lvs->urb);
}