diff options
author | Gao Xiang <gaoxiang25@huawei.com> | 2019-08-30 00:38:27 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-08-30 09:02:02 +0200 |
commit | 8d8a09b093d7073465c824f74caf315c073d3875 (patch) | |
tree | 787aaad384401dd763dc4541684055b88563c1bc /fs/erofs/data.c | |
parent | 5cf89673645f7edfa075afc9e1d531db24706329 (diff) | |
download | linux-next-8d8a09b093d7073465c824f74caf315c073d3875.tar.gz |
erofs: remove all likely/unlikely annotations
As Dan Carpenter suggested [1], I have to remove
all erofs likely/unlikely annotations.
[1] https://lore.kernel.org/linux-fsdevel/20190829154346.GK23584@kadam/
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Link: https://lore.kernel.org/r/20190829163827.203274-1-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/erofs/data.c')
-rw-r--r-- | fs/erofs/data.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/fs/erofs/data.c b/fs/erofs/data.c index fda16ec8863e..0f2f1a839372 100644 --- a/fs/erofs/data.c +++ b/fs/erofs/data.c @@ -27,7 +27,7 @@ static inline void read_endio(struct bio *bio) /* page is already locked */ DBG_BUGON(PageUptodate(page)); - if (unlikely(err)) + if (err) SetPageError(page); else SetPageUptodate(page); @@ -53,7 +53,7 @@ struct page *__erofs_get_meta_page(struct super_block *sb, repeat: page = find_or_create_page(mapping, blkaddr, gfp); - if (unlikely(!page)) { + if (!page) { DBG_BUGON(nofail); return ERR_PTR(-ENOMEM); } @@ -70,7 +70,7 @@ repeat: } err = bio_add_page(bio, page, PAGE_SIZE, 0); - if (unlikely(err != PAGE_SIZE)) { + if (err != PAGE_SIZE) { err = -EFAULT; goto err_out; } @@ -81,7 +81,7 @@ repeat: lock_page(page); /* this page has been truncated by others */ - if (unlikely(page->mapping != mapping)) { + if (page->mapping != mapping) { unlock_repeat: unlock_page(page); put_page(page); @@ -89,7 +89,7 @@ unlock_repeat: } /* more likely a read error */ - if (unlikely(!PageUptodate(page))) { + if (!PageUptodate(page)) { if (io_retries) { --io_retries; goto unlock_repeat; @@ -120,7 +120,7 @@ static int erofs_map_blocks_flatmode(struct inode *inode, nblocks = DIV_ROUND_UP(inode->i_size, PAGE_SIZE); lastblk = nblocks - is_inode_flat_inline(inode); - if (unlikely(offset >= inode->i_size)) { + if (offset >= inode->i_size) { /* leave out-of-bound access unmapped */ map->m_flags = 0; map->m_plen = 0; @@ -170,7 +170,7 @@ err_out: int erofs_map_blocks(struct inode *inode, struct erofs_map_blocks *map, int flags) { - if (unlikely(is_inode_layout_compression(inode))) { + if (is_inode_layout_compression(inode)) { int err = z_erofs_map_blocks_iter(inode, map, flags); if (map->mpage) { @@ -218,11 +218,11 @@ submit_bio_retry: unsigned int blkoff; err = erofs_map_blocks(inode, &map, EROFS_GET_BLOCKS_RAW); - if (unlikely(err)) + if (err) goto err_out; /* zero out the holed page */ - if (unlikely(!(map.m_flags & EROFS_MAP_MAPPED))) { + if (!(map.m_flags & EROFS_MAP_MAPPED)) { zero_user_segment(page, 0, PAGE_SIZE); SetPageUptodate(page); @@ -315,7 +315,7 @@ has_updated: submit_bio_out: __submit_bio(bio, REQ_OP_READ, 0); - return unlikely(err) ? ERR_PTR(err) : NULL; + return err ? ERR_PTR(err) : NULL; } /* @@ -377,7 +377,7 @@ static int erofs_raw_access_readpages(struct file *filp, DBG_BUGON(!list_empty(pages)); /* the rare case (end in gaps) */ - if (unlikely(bio)) + if (bio) __submit_bio(bio, REQ_OP_READ, 0); return 0; } |