summaryrefslogtreecommitdiff
path: root/lib/flex_array.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2012-04-23 15:58:47 +1000
committerBen Myers <bpm@sgi.com>2012-05-14 16:20:43 -0500
commitead360c50d33772f45943792893a58865adf3638 (patch)
tree08f737048596c1460c93428b7884f5bdc4732579 /lib/flex_array.c
parent0e95f19ad983e72a9cb93a67b3290b58f0467b36 (diff)
downloadlinux-next-ead360c50d33772f45943792893a58865adf3638.tar.gz
xfs: fix incorrect b_offset initialisation
Because we no longer use the page cache for buffering, there is no direct block number to page offset relationship anymore. xfs_buf_get_pages is still setting up b_offset as if there was some relationship, and that is leading to incorrectly setting up *uncached* buffers that don't overwrite b_offset once they've had pages allocated. For cached buffers, the first block of the buffer is always at offset zero into the allocated memory. This is true for sub-page sized buffers, as well as for multiple-page buffers. For uncached buffers, b_offset is only non-zero when we are associating specific memory to the buffers, and that is set correctly by the code setting up the buffer. Hence remove the setting of b_offset in xfs_buf_get_pages, because it is now always the wrong thing to do. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mark Tinguely <tinguely@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'lib/flex_array.c')
0 files changed, 0 insertions, 0 deletions