summaryrefslogtreecommitdiff
path: root/net/nfc
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2011-12-16 23:25:29 +0300
committerJohn W. Linville <linville@tuxdriver.com>2011-12-19 14:40:22 -0500
commit341ee4349f31e42fb0eb20d340d15309ac760308 (patch)
treee6fe061306ac9aa3628bd6ed23ca1d20e92ae164 /net/nfc
parentbad6919469662b7c92bc6353642aaaa777b36bac (diff)
downloadlinux-next-341ee4349f31e42fb0eb20d340d15309ac760308.tar.gz
NFC: double unlock in nfc_llcp_recv_connect()
We unlock inside the if block on the other side of this if else statement. It could result in calling mutex_unlock() twice. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/nfc')
-rw-r--r--net/nfc/llcp/llcp.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c
index 67756b23eac5..f99d6b4658ed 100644
--- a/net/nfc/llcp/llcp.c
+++ b/net/nfc/llcp/llcp.c
@@ -554,11 +554,9 @@ static void nfc_llcp_recv_connect(struct nfc_llcp_local *local,
goto enqueue;
}
}
-
+ mutex_unlock(&local->socket_lock);
}
- mutex_unlock(&local->socket_lock);
-
reason = LLCP_DM_NOBOUND;
goto fail;