diff options
| author | Andrew Morton <akpm@linux-foundation.org> | 2020-03-13 16:09:23 +1100 |
|---|---|---|
| committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2020-03-13 16:09:23 +1100 |
| commit | 6f152feeb8efd6838c6859b13fe336f6b7dbffec (patch) | |
| tree | 0251d0a8690e64dd997b8cabad54583cce08b1d9 /tools | |
| parent | 3ad5669ac34cddd09adcafd0c6d6d270aaaf15dd (diff) | |
| download | linux-next-6f152feeb8efd6838c6859b13fe336f6b7dbffec.tar.gz | |
selftest-add-mremap_dontunmap-selftest-v7-checkpatch-fixes
ERROR: Bad function definition - void mremap_dontunmap_partial_mapping_overwrite() should probably be void mremap_dontunmap_partial_mapping_overwrite(void)
#34: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:228:
+static void mremap_dontunmap_partial_mapping_overwrite()
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#68: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:251:
+ BUG_ON(source_mapping == MAP_FAILED, "mmap");
WARNING: line over 80 characters
#109: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:264:
+ MREMAP_DONTUNMAP | MREMAP_MAYMOVE | MREMAP_FIXED, dest_mapping);
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#110: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:265:
+ BUG_ON(dest_mapping == MAP_FAILED, "mremap");
WARNING: line over 80 characters
#111: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:266:
+ BUG_ON(dest_mapping != remapped_mapping, "expected to remap to dest_mapping");
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#111: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:266:
+ BUG_ON(dest_mapping != remapped_mapping, "expected to remap to dest_mapping");
WARNING: line over 80 characters
#120: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:272:
+ BUG_ON(check_region_contains_byte(dest_mapping, 5 * page_size, 'a') != 0,
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#120: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:272:
+ BUG_ON(check_region_contains_byte(dest_mapping, 5 * page_size, 'a') != 0,
WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#133: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:280:
+ BUG_ON(munmap(dest_mapping, 10 * page_size) == -1,
total: 1 errors, 8 warnings, 126 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/selftest-add-mremap_dontunmap-selftest-v7.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Brian Geffon <bgeffon@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/testing/selftests/vm/mremap_dontunmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/vm/mremap_dontunmap.c b/tools/testing/selftests/vm/mremap_dontunmap.c index 23240ee1e384..ee06cb0b9efb 100644 --- a/tools/testing/selftests/vm/mremap_dontunmap.c +++ b/tools/testing/selftests/vm/mremap_dontunmap.c @@ -225,7 +225,7 @@ static void mremap_dontunmap_partial_mapping() } // This test validates that we can remap over only a portion of a mapping. -static void mremap_dontunmap_partial_mapping_overwrite() +static void mremap_dontunmap_partial_mapping_overwrite(void) { /* * source mapping: |