diff options
| author | Josh Cartwright <joshc@ni.com> | 2015-10-27 07:31:53 -0500 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2016-11-16 14:23:15 -0500 |
| commit | 4a388980045ddbedeeb31b39e46c69dd350e051f (patch) | |
| tree | bc325fa73a585e1577ee770b5658a425169af342 | |
| parent | 901ef9a1a5d22b3ff9338ab8d653041f605742eb (diff) | |
| download | linux-rt-4a388980045ddbedeeb31b39e46c69dd350e051f.tar.gz | |
net: Make synchronize_rcu_expedited() conditional on !RT_FULL
While the use of synchronize_rcu_expedited() might make
synchronize_net() "faster", it does so at significant cost on RT
systems, as expediting a grace period forcibly preempts any
high-priority RT tasks (via the stop_machine() mechanism).
Without this change, we can observe a latency spike up to 30us with
cyclictest by rapidly unplugging/reestablishing an ethernet link.
Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Josh Cartwright <joshc@ni.com>
Cc: bigeasy@linutronix.de
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20151027123153.GG8245@jcartwri.amer.corp.natinst.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 4e6b2fd65a57..28bf8b874884 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -6086,7 +6086,7 @@ EXPORT_SYMBOL(free_netdev); void synchronize_net(void) { might_sleep(); - if (rtnl_is_locked()) + if (rtnl_is_locked() && !IS_ENABLED(CONFIG_PREEMPT_RT_FULL)) synchronize_rcu_expedited(); else synchronize_rcu(); |