diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2016-06-07 21:26:55 -0400 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2016-08-22 22:37:13 +0100 |
commit | 37f4f9e677576c8f8add9f43844c6c468caf8252 (patch) | |
tree | 54ce068b2ec4b3006f80e615426ce889c1f19931 /fs/ocfs2/acl.c | |
parent | 44854a56abe939405bf4792e9bbdaded5f28897d (diff) | |
download | linux-rt-37f4f9e677576c8f8add9f43844c6c468caf8252.tar.gz |
fix d_walk()/non-delayed __d_free() race
commit 3d56c25e3bb0726a5c5e16fc2d9e38f8ed763085 upstream.
Ascend-to-parent logics in d_walk() depends on all encountered child
dentries not getting freed without an RCU delay. Unfortunately, in
quite a few cases it is not true, with hard-to-hit oopsable race as
the result.
Fortunately, the fix is simiple; right now the rule is "if it ever
been hashed, freeing must be delayed" and changing it to "if it
ever had a parent, freeing must be delayed" closes that hole and
covers all cases the old rule used to cover. Moreover, pipes and
sockets remain _not_ covered, so we do not introduce RCU delay in
the cases which are the reason for having that delay conditional
in the first place.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
[bwh: Backported to 3.2:
- Adjust context
- Also set the flag in __d_materialise_dentry())]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'fs/ocfs2/acl.c')
0 files changed, 0 insertions, 0 deletions