summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2018-04-07 13:42:37 -0700
committerSasha Levin <alexander.levin@microsoft.com>2018-05-22 21:36:40 -0400
commit84889429a9a075e4da15bf24911e06dcc2c3bb4f (patch)
tree61130adf54b8d0c64bf4dbb4bcc8a5c15f06c968
parenta82b0b8ad435f93b287832e32947d994a18d6796 (diff)
downloadlinux-stable-84889429a9a075e4da15bf24911e06dcc2c3bb4f.tar.gz
netlink: fix uninit-value in netlink_sendmsg
[ Upstream commit 6091f09c2f79730d895149bcfe3d66140288cd0e ] syzbot reported : BUG: KMSAN: uninit-value in ffs arch/x86/include/asm/bitops.h:432 [inline] BUG: KMSAN: uninit-value in netlink_sendmsg+0xb26/0x1310 net/netlink/af_netlink.c:1851 Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
-rw-r--r--net/netlink/af_netlink.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 8c3194bbe2d2..45ecf1f433ad 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2388,6 +2388,8 @@ static int netlink_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
if (msg->msg_namelen) {
err = -EINVAL;
+ if (msg->msg_namelen < sizeof(struct sockaddr_nl))
+ goto out;
if (addr->nl_family != AF_NETLINK)
goto out;
dst_portid = addr->nl_pid;