diff options
| author | Johan Hovold <jhovold@gmail.com> | 2012-10-25 13:35:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-31 10:10:17 -0700 |
| commit | da0d04fd143824b6d2657c267a8a09517194370b (patch) | |
| tree | 2711ec7ad4476ebbc820b3fe7a0c6ec8143988c7 | |
| parent | f36791258f9c7da44ba15aa64f3eb284b67b9939 (diff) | |
| download | linux-da0d04fd143824b6d2657c267a8a09517194370b.tar.gz | |
USB: mos7840: fix port-device leak in error path
commit 3eb55cc4ed88eee3b5230f66abcdbd2a91639eda upstream.
The driver set the usb-serial port pointers to NULL on errors in attach,
effectively preventing usb-serial core from decrementing the port ref
counters and releasing the port devices and associated data.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 23c06fd4a157..bff3f8e87987 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -2684,7 +2684,6 @@ error: kfree(mos7840_port->ctrl_buf); usb_free_urb(mos7840_port->control_urb); kfree(mos7840_port); - serial->port[i] = NULL; } return status; } |