diff options
| author | Slark Xiao <slark_xiao@163.com> | 2022-06-22 14:21:13 +0800 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2022-06-22 08:56:52 +0200 |
| commit | 7828466cff6b38c2a8ea7cc43958e3abe04342c2 (patch) | |
| tree | 65b26b2ebab71b53ea74da7cc9a50af3ca20f4fd /drivers/usb/serial/sierra.c | |
| parent | a111daf0c53ae91e71fd2bfe7497862d14132e3e (diff) | |
| download | linux-7828466cff6b38c2a8ea7cc43958e3abe04342c2.tar.gz | |
USB: serial: use kmemdup instead of kmalloc + memcpy
For code neat purpose, we can use kmemdup to replace
kmalloc + memcpy.
Signed-off-by: Slark Xiao <slark_xiao@163.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/sierra.c')
| -rw-r--r-- | drivers/usb/serial/sierra.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c index 9d56138133a9..525c7f888c90 100644 --- a/drivers/usb/serial/sierra.c +++ b/drivers/usb/serial/sierra.c @@ -453,7 +453,7 @@ static int sierra_write(struct tty_struct *tty, struct usb_serial_port *port, goto error_simple; } - buffer = kmalloc(writesize, GFP_ATOMIC); + buffer = kmemdup(buf, writesize, GFP_ATOMIC); if (!buffer) { retval = -ENOMEM; goto error_no_buffer; @@ -465,8 +465,6 @@ static int sierra_write(struct tty_struct *tty, struct usb_serial_port *port, goto error_no_urb; } - memcpy(buffer, buf, writesize); - usb_serial_debug_data(&port->dev, __func__, writesize, buffer); usb_fill_bulk_urb(urb, serial->dev, |