summaryrefslogtreecommitdiff
path: root/drivers
Commit message (Collapse)AuthorAgeFilesLines
* [IPoIB] remove unneeded initializations to 0Roland Dreier2005-11-021-9/+2
| | | | | | | Shrink our source and .text a little by removing a few assignments of NULL and 0 to memory that is already cleared as part of the allocation. Signed-off-by: Roland Dreier <rolandd@cisco.com>
* [IB] kzalloc() conversionsRoland Dreier2005-11-0211-62/+27
| | | | | | | Replace kmalloc()+memset(,0,) with kzalloc(), for a net savings of 35 source lines and about 500 bytes of text. Signed-off-by: Roland Dreier <rolandd@cisco.com>
* [IPoIB] cleanups: fix comment, remove useless variablesRoland Dreier2005-10-312-9/+7
| | | | | | | | Minor cleanups: fix a misleading comment, and get rid of attr_mask variables that are only used to hold constants (just use the constants directly). Signed-off-by: Roland Dreier <rolandd@cisco.com>
* [IB] mthca: Avoid SRQ free WQE list corruptionRoland Dreier2005-10-311-6/+7
| | | | | | | | Fix wqe_to_link() to use a structure field that we know is definitely always unused for receive work requests, so that it really avoids the free list corruption bug that the comment claims it does. Signed-off-by: Roland Dreier <rolandd@cisco.com>
* [IB] uverbs: Avoid NULL pointer deref on CQ async eventRoland Dreier2005-10-313-6/+5
| | | | | | | | | Userspace CQs that have no completion event channel attached end up with their cq_context set to NULL. However, asynchronous events like "CQ overrun" can still occur on such CQs, so add a uverbs_file member to struct ib_ucq_object that we can follow to deliver these events. Signed-off-by: Roland Dreier <rolandd@cisco.com>
* [IPoIB] use spin_trylock_irqsave()Roland Dreier2005-10-291-4/+1
| | | | | | | | Use spin_trylock_irqsave() in ipoib_start_xmit() instead of reinventing it out of local_irq_save(), spin_trylock() and local_irq_restore(). Signed-off-by: Roland Dreier <rolandd@cisco.com>
* [IB] mthca: report asynchronous CQ eventsMichael S. Tsirkin2005-10-293-3/+36
| | | | | | | Implement reporting asynchronous CQ events in Mellanox HCA driver. Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
* Merge branch 'for-linus' of ↵Linus Torvalds2005-10-2838-1678/+2448
|\ | | | | | | master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband
| * [IB] fix up class_device_create() callsRoland Dreier2005-10-282-3/+4
| | | | | | | | | | | | | | Fix class_device_create() calls to match the new prototype which takes a parent device pointer. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * Merge master.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux-2.6Roland Dreier2005-10-28560-12547/+19412
| |\
| * | [IB] uverbs: Fix device lifetime problemsRoland Dreier2005-10-283-95/+182
| | | | | | | | | | | | | | | | | | | | | | | | | | | Move ib_uverbs module to using cdev_alloc() and class_device_create() so that we can handle device lifetime properly. Now we can make sure we keep all of our data structures around until the last way to reach them is gone. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] umad: Fix device lifetime problemsRoland Dreier2005-10-281-109/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | Move ib_umad module to using cdev_alloc() and class_device_create() so that we can handle device lifetime properly. Now we can make sure we keep all of our data structures around until the last way to reach them is gone. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IPoIB] Drop RX packets when out of memoryRoland Dreier2005-10-283-60/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the way IPoIB handles RX packets when it can't allocate a new receive skbuff. If the allocation of a new receive skb fails, we now drop the packet we just received and repost the original receive skb. This means that the receive ring always stays full and we don't have to monkey around with trying to schedule a refill task for later. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] ib_umad: various cleanupsSean Hefty2005-10-271-52/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Simplify user_mad.c code in a few places, and convert from kmalloc() + memset() to kzalloc(). This also fixes a theoretical race window by not accessing packet->length after posting the send buffer (the send could complete and packet could be freed before we get to the return statement at the end of ib_umad_write()). Signed-off-by: Sean Hefty <sean.hefty@intel.com> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] ib_umad: fix crash when freeing send buffersRoland Dreier2005-10-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | The conversion of user_mad.c to the new MAD send API was slightly off: in a few places, we used packet->msg instead of packet->msg->mad when referring to the actual data buffer, which ended up corrupting the underlying data structure and crashing when we free an invalid pointer. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] mthca: first pass at catastrophic error reportingRoland Dreier2005-10-275-1/+176
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add some initial support for detecting and reporting catastrophic errors reported by Mellanox HCAs. We start a periodic timer which polls the catastrophic error reporting buffer in device memory. If an error is detected, we dump the contents of the buffer for port-mortem debugging, and report a fatal asynchronous error to higher levels. In the future we can try to recover from these errors by resetting the device, but this will require some work in higher-level code as well. Let's get this in now, so that we at least get catastrophic errors reported in logs. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] simplify mad_rmpp.c:alloc_response_msg()Roland Dreier2005-10-251-16/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change alloc_response_msg() in mad_rmpp.c to return the struct it allocates directly (or an error code a la ERR_PTR), rather than returning a status and passing the struct back in a pointer param. This simplifies the code and gets rid of warnings like drivers/infiniband/core/mad_rmpp.c: In function nack_recv: drivers/infiniband/core/mad_rmpp.c:192: warning: msg may be used uninitialized in this function with newer versions of gcc. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] mthca: correct modify QP attribute masks for UCRoland Dreier2005-10-251-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | The UC transport does not support RDMA reads or atomic operations, so we shouldn't require or even allow the consumer to set attributes relating to these operations for UC QPs. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] Fix MAD layer DMA mappings to avoid touching data buffer once mappedSean Hefty2005-10-2512-809/+441
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MAD layer was violating the DMA API by touching data buffers used for sends after the DMA mapping was done. This causes problems on non-cache-coherent architectures, because the device doing DMA won't see updates to the payload buffers that exist only in the CPU cache. Fix this by having all MAD consumers use ib_create_send_mad() to allocate their send buffers, and moving the DMA mapping into the MAD layer so it can be done just before calling send (and after any modifications of the send buffer by the MAD layer). Tested on a non-cache-coherent PowerPC 440SPe system. Signed-off-by: Sean Hefty <sean.hefty@intel.com> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | [IB] CM: Fix initialization of QP attributes for UC QPs.Sean Hefty2005-10-241-14/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix cm_init_qp_init_attr(), cm_init_qp_rtr_attr() and cm_init_qp_rts_attr() so that they correctly handle the differences between UC and RC QPs. This fixes problems with setting up UC QPs through the CM. Signed-off-by: Sean Hefty <sean.hefty@intel.com> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | Manual merge of for-linus to upstream (fix conflicts in ↵Roland Dreier2005-10-2435-104/+175
| |\ \ | | | | | | | | | | | | drivers/infiniband/core/ucm.c)
| | * | [IB] Add idr_destroy() calls on module unloadRoland Dreier2005-10-244-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add idr_destroy() calls to the module_exit() functions of the four IB driver modules that use idrs, so we don't leak idr_layer_cache objects when these modules are unloaded. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] user_mad: Use class_device.devtRoland Dreier2005-10-201-15/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Use devt member of struct class_device so that we don't have to create our own "dev" file in sysfs. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] user_mad: trivial coding style fixesRoland Dreier2005-10-201-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | Add spaces after "sizeof" operator to match the rest of file. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] cm: Add missing break in switchRoland Dreier2005-10-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add missing "break" in switch statement. Without the break, the CM ended up always falling through and setting every connection request to use RC transport, which meant that UC connections didn't work. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: Don't enter QP into MCG more than once.Jack Morgenstein2005-10-181-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid entering a QP as member of a multicast group multiple times. Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] Fail sysfs queries after device is unregisteredRoland Dreier2005-10-181-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We keep IB device structures around until the last sysfs reference is gone, but we shouldn't ask the low-level driver to do anything after the LLD unregisters the device. To handle this, check the reg_state field and just fail sysfs show() requests if the device has already been unregistered. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: Add struct pci_driver.owner fieldRoland Dreier2005-10-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Set mthca_driver.owner to THIS_MODULE. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: Use enum in mthca_alloc_db() prototypeRoland Dreier2005-10-182-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the type parameter of mthca_alloc_db() be an enum mthca_db_type instead of an int. This doesn't have any practical effect but documents the functions a little better. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IPoIB] Improve ipoib_timeout() outputRoland Dreier2005-10-181-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use jiffies_to_msecs() so we print a human-readable time so we don't have to worry about what HZ is configured to, and print out a few values to make post-mortem analysis easier. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] ucm: quiet sparse warningsRoland Dreier2005-10-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Make ctx_id_mutex and ctx_id_table static to quiet sparse warnings. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] CM: bind IDs to a specific deviceSean Hefty2005-10-172-67/+192
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bind communication identifiers to a device to support device removal. Export per HCA CM devices to userspace. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
| * | | [IB] merge ucm.h into ucm.cSean Hefty2005-10-172-104/+41
| | | | | | | | | | | | | | | | | | | | | | | | Eliminate ucm.h. Replace ucm_dbg with direct call to printk KERN_ERR. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
| * | | [IB] uverbs: Implement more commandsRoland Dreier2005-10-173-1/+572
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add kernel support for userspace calling poll CQ, request CQ notification, post send, post receive, post SRQ receive, create AH and destroy AH commands. These commands allow us to support userspace verbs for devices that can't perform these operations directly from userspace (eg the PathScale HCA). Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] uverbs: Add a mask of device methods allowed for userspaceRoland Dreier2005-10-172-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Give each device a uverbs_cmd_mask, so that a low-level driver can control which methods may be called on behalf of userspace. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] fail SA queries if device initialization failedRoland Dreier2005-10-171-6/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the SA query module's initialization fails for a device, then that device won't have a struct ib_sa_device associated. We should fail SA queries in that case, rather than blindly dereferencing the NULL pointer we get back from ib_get_client_data(). Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] uverbs: unlock correctly in error pathsRoland Dreier2005-10-171-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | A couple of functions were missing spin_unlock calls in error paths. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IPoIB] Rename ipoib_create_qp() -> ipoib_init_qp() and fix error cleanupRoland Dreier2005-10-173-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ipoib_create_qp() no longer creates IPoIB's QP, so it shouldn't destroy the QP on failure -- that unwinding happens elsewhere, so the current code can cause a double free. While we're at it, the function's name should match what it actually does, so rename it to ipoib_init_qp(). Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: Better limit checking and reportingJack Morgenstein2005-10-177-12/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check the sizes of CQs, QPs and SRQs when creating objects, and fail instead of creating too-big queues. Also return real limits instead of just plausible-sounding values from mthca_query_device(). Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] Fix leak on MAD initialization failureRoland Dreier2005-10-171-19/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is a bug in ib_mad_init_device(): if ib_agent_port_open() fails for a given port, then the current code doesn't call ib_mad_port_close() for that port. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: detect SRQ overflowRoland Dreier2005-10-171-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The hardware relies on us keeping one extra work request that never gets used in SRQs. Add checks to the SRQ work request posting functions so that they fail when someone is about to use up that extra work request, rather than when someone uses the very last work request. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: SRQ limit reached eventsRoland Dreier2005-10-174-4/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our hardware supports generating an event when the number of receives posted to a shared receive queue (SRQ) falls below a user-specified limit. Implement mthca_modify_srq() to arm the limit, and add code to handle dispatching SRQ events when they occur. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] Check port number in ib_query_port()/ib_modify_port()Roland Dreier2005-10-171-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Check port number before passing query_port or modify_port operations on to device driver. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] uverbs: reject invalid memory registration permission flagsRoland Dreier2005-10-171-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reject userspace memory registrations with invalid permission flags: "local write" is required if "remote write" or "remote atomic" is also requested. Pointed out by Jack Morgenstein <jackm@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: Fill in more fields in query_port methodJack Morgenstein2005-10-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add code to fill in the bad_pkey_cntr, max_mtu, active_mtu and subnet_timeout fields in mthca_query_port(). Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] uverbs: Add device-specific ABI version attributeRoland Dreier2005-10-173-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add abi_version attribute to uverbs class devices to allow for ABI versioning of device-specific interfaces. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] uverbs: Fix up resource creation error pathsRoland Dreier2005-10-171-61/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By waiting to add resources to our lists until after the last operation that can fail, we don't have to remove them from their lists in the error path. Also, we should hold the idr mutex until we know whether resource creation has succeed or failed, to avoid someone finding a resource in our table before we're ready. Loosely based on work by Robert Walsh <rjwalsh@pathscale.com>. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] uverbs: ABI-breaking fixes for userspace verbsRoland Dreier2005-10-173-252/+244
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduce new userspace verbs ABI version 3. This eliminates some unneeded commands, and adds support for user-created completion channels. This cleans up problems with file leaks on error paths, and also makes sure that file descriptors are always installed into the correct process. Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] mthca: Report correct atomic capabilityJack Morgenstein2005-10-173-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Return correct atomic capability flag from mthca query function. Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
| * | | [IB] Add checks to multicast attach and detachJack Morgenstein2005-10-171-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add checks so that we only allow multicast attach/detach with a valid multicast GID and the correct QP type. Signed-off-by: Jack Morgenstein <jackm@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
View Lorry Controller Status